Skip to content

Add krew plugin definition for 'walk'#5663

Open
HarshPanchal18 wants to merge 4 commits into
kubernetes-sigs:masterfrom
HarshPanchal18:master
Open

Add krew plugin definition for 'walk'#5663
HarshPanchal18 wants to merge 4 commits into
kubernetes-sigs:masterfrom
HarshPanchal18:master

Conversation

@HarshPanchal18
Copy link
Copy Markdown

No description provided.

This YAML file defines the krew plugin 'walk' with version v1.1.0, including platform-specific binaries for Linux, Darwin, and Windows.
@ahmetb
Copy link
Copy Markdown
Member

ahmetb commented Apr 27, 2026

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HarshPanchal18
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2026
@ahmetb
Copy link
Copy Markdown
Member

ahmetb commented Apr 27, 2026

I have not tried the plugin but it seems like you've reimplemented these two existing tools:

it doesn't concern me a lot but you'd be spending time maintaining something that already exists if the functionality already exists by composing other tools.

@HarshPanchal18
Copy link
Copy Markdown
Author

HarshPanchal18 commented Apr 27, 2026

Hey @ahmetb , I wasn't aware of both this utils until now. I looked around both of them. The gron comes closer to this plugin. However, the plugin has native support for Kubernetes resources and works smoothly with the rich set of flags and parameters. Several more updates are in the queue. Give it a shot once you catch some time. 👍🏼

@ahmetb
Copy link
Copy Markdown
Member

ahmetb commented Apr 27, 2026

I don't think the tool works well yet.
/hold

I recommend you polish the plugin more. Maybe read some articles like https://iximiuz.com/en/posts/kubernetes-api-go-cli/ or look at the source of https://github.com/ahmetb/kubectl-cond to figure out how to select objects. If you reimplement it, you'll probably get it wrong.

$ k walk ns default
error: resource not found: ns
$  k walk namespace default
error: the server could not find the requested resource

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2026
@HarshPanchal18
Copy link
Copy Markdown
Author

Can you test and review again, pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants