Add krew plugin definition for 'walk'#5663
Conversation
This YAML file defines the krew plugin 'walk' with version v1.1.0, including platform-specific binaries for Linux, Darwin, and Windows.
|
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HarshPanchal18 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I have not tried the plugin but it seems like you've reimplemented these two existing tools:
it doesn't concern me a lot but you'd be spending time maintaining something that already exists if the functionality already exists by composing other tools. |
|
Hey @ahmetb , I wasn't aware of both this utils until now. I looked around both of them. The gron comes closer to this plugin. However, the plugin has native support for Kubernetes resources and works smoothly with the rich set of flags and parameters. Several more updates are in the queue. Give it a shot once you catch some time. 👍🏼 |
|
I don't think the tool works well yet. I recommend you polish the plugin more. Maybe read some articles like https://iximiuz.com/en/posts/kubernetes-api-go-cli/ or look at the source of https://github.com/ahmetb/kubectl-cond to figure out how to select objects. If you reimplement it, you'll probably get it wrong. |
|
Can you test and review again, pls? |
No description provided.