Skip to content

Add aperf plugin#5599

Open
chrismld wants to merge 4 commits into
kubernetes-sigs:masterfrom
chrismld:add-aperf-plugin
Open

Add aperf plugin#5599
chrismld wants to merge 4 commits into
kubernetes-sigs:masterfrom
chrismld:add-aperf-plugin

Conversation

@chrismld
Copy link
Copy Markdown

APerf is a performance monitoring and debugging tool for Linux systems. It collects system metrics (CPU, memory, disk, PMU counters, etc.) and generates interactive HTML reports with automated analysis.

The kubectl plugin deploys a privileged pod on a target node, runs aperf, and copies the report back locally.

Homepage: https://github.com/aws/aperf

@ahmetb
Copy link
Copy Markdown
Member

ahmetb commented Apr 15, 2026

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 15, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrismld
Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @chrismld!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 15, 2026
@chrismld
Copy link
Copy Markdown
Author

I noticed the aperf release artifacts don't include the LICENSE file, I'll update this PR when the file is there ... sorry about this, let me know if you prefer me to close this PR and open a new one later on.

Copy link
Copy Markdown
Member

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this plugin.
You're representing AWS at an official capacity, correct? In that case no concerns assigning aperf name.

Comment thread plugins/aperf.yaml Outdated
uri: https://github.com/aws/aperf/releases/download/v1.2.2/kubectl-aperf-v1.2.2.tar.gz
sha256: 1262849aba55ddbe3a3aab4641a18d7379c79b40ff17af0894758e93f32290a8
files:
- from: kubectl-aperf-v1.2.2/kubectl-aperf
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove version field from this? your version bumps won't be auto merged otherwise. see all other plugins.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ahmet, I changed the name as other plugins are doing it

@chrismld
Copy link
Copy Markdown
Author

Thanks for submitting this plugin. You're representing AWS at an official capacity, correct? In that case no concerns assigning aperf name.

Yes, I work at AWS, let me know if you need something else ... I noticed we have to include the LICENSE file, which is something we're not doing yet, it will come in the next release. So I guess that if everything looks good, I'll just come back here to let you know when the new aperf release is published.

@ahmetb
Copy link
Copy Markdown
Member

ahmetb commented May 15, 2026

Sounds good, btw you have issues with plugin path in the tarball archive as well I believe.

@chrismld
Copy link
Copy Markdown
Author

alright, it seems that I fixed the plugin path but it's still failing because of the missing LICENSE file ... I'll come back to update the sha256 when the new release is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants