Add aperf plugin#5599
Conversation
|
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrismld The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @chrismld! |
00febf8 to
c144329
Compare
|
I noticed the aperf release artifacts don't include the LICENSE file, I'll update this PR when the file is there ... sorry about this, let me know if you prefer me to close this PR and open a new one later on. |
ahmetb
left a comment
There was a problem hiding this comment.
Thanks for submitting this plugin.
You're representing AWS at an official capacity, correct? In that case no concerns assigning aperf name.
| uri: https://github.com/aws/aperf/releases/download/v1.2.2/kubectl-aperf-v1.2.2.tar.gz | ||
| sha256: 1262849aba55ddbe3a3aab4641a18d7379c79b40ff17af0894758e93f32290a8 | ||
| files: | ||
| - from: kubectl-aperf-v1.2.2/kubectl-aperf |
There was a problem hiding this comment.
can you remove version field from this? your version bumps won't be auto merged otherwise. see all other plugins.
There was a problem hiding this comment.
thanks Ahmet, I changed the name as other plugins are doing it
Yes, I work at AWS, let me know if you need something else ... I noticed we have to include the LICENSE file, which is something we're not doing yet, it will come in the next release. So I guess that if everything looks good, I'll just come back here to let you know when the new aperf release is published. |
|
Sounds good, btw you have issues with plugin path in the tarball archive as well I believe. |
|
alright, it seems that I fixed the plugin path but it's still failing because of the missing LICENSE file ... I'll come back to update the sha256 when the new release is out |
APerf is a performance monitoring and debugging tool for Linux systems. It collects system metrics (CPU, memory, disk, PMU counters, etc.) and generates interactive HTML reports with automated analysis.
The kubectl plugin deploys a privileged pod on a target node, runs aperf, and copies the report back locally.
Homepage: https://github.com/aws/aperf