Skip to content

use kind build node images instead of relying on official images #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kannon92 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

use kind build node images instead of relying on official images #1234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions hack/e2e-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export NAMESPACE="jobset-system"
export JOBSET_E2E_TESTS_DUMP_NAMESPACE=true
# E2E config folder to use (defaults to "default")
export E2E_TARGET_FOLDER="${E2E_TARGET_FOLDER:-default}"
K8S_VERSION="${E2E_KIND_VERSION##*:}"
Comment thread
kannon92 marked this conversation as resolved.

# Use a temporary KUBECONFIG so that the script does not mess with the current user's kubeconfig.
KUBECONFIG=""
Expand All @@ -25,6 +26,14 @@ function cleanup {
fi
(cd config/components/manager && $KUSTOMIZE edit set image controller=us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset:main)
}

function build_node_image {

if [ $USE_EXISTING_CLUSTER == 'false' ]
then
$KIND build node-image $K8S_VERSION --image jobset/kind-node:${K8S_VERSION}
fi
Comment thread
kannon92 marked this conversation as resolved.
}
function startup {
if [ $USE_EXISTING_CLUSTER == 'false' ]
then
Expand All @@ -34,7 +43,7 @@ function startup {
exit 1
fi
export KUBECONFIG
$KIND create cluster --name $KIND_CLUSTER_NAME --image $E2E_KIND_VERSION --wait 1m
$KIND create cluster --name $KIND_CLUSTER_NAME --image jobset/kind-node:${K8S_VERSION} --wait 1m
kubectl get nodes > $ARTIFACTS/kind-nodes.log || true
kubectl describe pods -n kube-system > $ARTIFACTS/kube-system-pods.log || true
fi
Expand All @@ -49,7 +58,8 @@ function jobset_deploy {
kubectl apply --server-side -k test/e2e/config/$E2E_TARGET_FOLDER
}
trap cleanup EXIT
build_node_image
startup
kind_load
jobset_deploy
$GINKGO --junit-report=junit.xml --output-dir=$ARTIFACTS -v ./test/e2e/...
$GINKGO --junit-report=junit.xml --output-dir=$ARTIFACTS -v ./test/e2e/...