frontend: ObjectEventList: Fix Age column text clipping in details panel#5730
frontend: ObjectEventList: Fix Age column text clipping in details panel#5730Swastik19Nit wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Swastik19Nit The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
illume
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
The GitHub CI test job has snapshot failures. Run cd frontend && npm run test -- -u to regenerate the snapshots.
How to update snapshots
Run cd frontend && npm run test -- -u to regenerate all snapshots. Review the diff to make sure the visual changes are intentional, then commit the updated snapshot files.
There was a problem hiding this comment.
Pull request overview
Fixes clipping of the Age column in the Events table inside the right-side details panel by allowing the HoverInfoLabel text to wrap instead of using the default nowrap style.
Changes:
- Pass
labelPropswithwhiteSpace: 'normal'andoverflowWrap: 'anywhere'to theHoverInfoLabelrendering the Age column inObjectEventList.
|
Thanks i have updated story snapshot |
illume
left a comment
There was a problem hiding this comment.
Thanks for these changes.
Can you please have a look at the git commits to see if they meet the contribution guidelines? We use a Linux kernel style of git commits. See the contributing guide for general context, and please see previous git commits with git log for examples.
Commits that need attention
test: update ObjectEventList story snapshot— Missingarea: descriptionprefix — e.g.frontend: HomeButton: Fix so it navigates to homeorbackend: config: Add enable-dynamic-clusters flag.
Commit guidelines
- Use atomic commits focused on a single change.
- Use the title format
<area>: <Description of changes>— description must start with a capital letter. - Keep the title under 72 characters (soft requirement).
- Explain the intention and why the change is needed.
- Make commit titles meaningful and describe what changed.
- Do not add code that a later commit rewrites; squash or reorder commits instead.
- Do not include
Fixes #NNin commit messages.
Good examples:
frontend: HomeButton: Fix so it navigates to homebackend: config: Add enable-dynamic-clusters flag
The age column in the events table was getting clipped inside the details panel because
HoverInfoLabelforceswhiteSpace: nowrapon its label. In a narrow panel like the right side drawer so this causes the age text to overflow and get cut off.Fixes #5729
After fix it looks like