Skip to content

frontend: ObjectEventList: Fix Age column text clipping in details panel#5730

Open
Swastik19Nit wants to merge 2 commits into
kubernetes-sigs:mainfrom
Swastik19Nit:fix/simple-table-overflow
Open

frontend: ObjectEventList: Fix Age column text clipping in details panel#5730
Swastik19Nit wants to merge 2 commits into
kubernetes-sigs:mainfrom
Swastik19Nit:fix/simple-table-overflow

Conversation

@Swastik19Nit
Copy link
Copy Markdown

@Swastik19Nit Swastik19Nit commented May 17, 2026

The age column in the events table was getting clipped inside the details panel because HoverInfoLabel forces whiteSpace: nowrap on its label. In a narrow panel like the right side drawer so this causes the age text to overflow and get cut off.

Fixes #5729

After fix it looks like

image

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Swastik19Nit
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2026
@illume illume requested a review from Copilot May 18, 2026 07:11
Copy link
Copy Markdown
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

The GitHub CI test job has snapshot failures. Run cd frontend && npm run test -- -u to regenerate the snapshots.

How to update snapshots

Run cd frontend && npm run test -- -u to regenerate all snapshots. Review the diff to make sure the visual changes are intentional, then commit the updated snapshot files.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes clipping of the Age column in the Events table inside the right-side details panel by allowing the HoverInfoLabel text to wrap instead of using the default nowrap style.

Changes:

  • Pass labelProps with whiteSpace: 'normal' and overflowWrap: 'anywhere' to the HoverInfoLabel rendering the Age column in ObjectEventList.

@Swastik19Nit
Copy link
Copy Markdown
Author

Thanks i have updated story snapshot

@Swastik19Nit Swastik19Nit requested a review from illume May 18, 2026 17:38
@illume illume requested a review from Copilot May 19, 2026 14:41
Copy link
Copy Markdown
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes.

Can you please have a look at the git commits to see if they meet the contribution guidelines? We use a Linux kernel style of git commits. See the contributing guide for general context, and please see previous git commits with git log for examples.

Commits that need attention
  • test: update ObjectEventList story snapshot — Missing area: description prefix — e.g. frontend: HomeButton: Fix so it navigates to home or backend: config: Add enable-dynamic-clusters flag.
Commit guidelines
  • Use atomic commits focused on a single change.
  • Use the title format <area>: <Description of changes> — description must start with a capital letter.
  • Keep the title under 72 characters (soft requirement).
  • Explain the intention and why the change is needed.
  • Make commit titles meaningful and describe what changed.
  • Do not add code that a later commit rewrites; squash or reorder commits instead.
  • Do not include Fixes #NN in commit messages.

Good examples:

  • frontend: HomeButton: Fix so it navigates to home
  • backend: config: Add enable-dynamic-clusters flag

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend: Events/Conditions table clips last column (Age) in the details panel

4 participants