frontend: Add ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding views by ManthanNimodiya · Pull Request #5524 · kubernetes-sigs/headlamp

ManthanNimodiya · 2026-05-10T10:57:54Z

Summary

Adds list and detail views for ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding resources under the Configuration section in the sidebar.

Related Issue

Fixes #4755

Changes

Added K8s classes for both resources (admissionregistration.k8s.io/v1, cluster-scoped)
Added list and detail views for both resources
Registered routes and sidebar entries under Configuration
Added i18n strings

Steps to Test

Connect Headlamp to a Kubernetes v1.30+ cluster
Expand Configuration in the sidebar — both new entries should appear
Click each — list pages should load without errors

Screenshots

k8s-ci-robot · 2026-05-10T10:58:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ManthanNimodiya
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

illume

Thanks for this PR.

the PR has a merge-main commit; please rebase against main to keep the history clean.

Why this matters

Merge commits from main make the PR history harder to review. Please rebase your branch on top of the latest main instead, then update the PR with the rebased commits.

Copilot

Pull request overview

Adds UI support in the Headlamp frontend for Kubernetes ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding (admissionregistration.k8s.io/v1) by introducing new K8s resource classes, list/detail pages, routes, and sidebar navigation entries. The PR also includes Helm chart NOTES/README updates about pinned image.tag upgrade behavior (CI status and commit history details were not available in this review context—please confirm checks are green and history is linear).

Changes:

Added new K8s resource classes for ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding (cluster-scoped).
Added list and detail views, plus routes and sidebar entries under Configuration.
Updated Helm chart docs/NOTES to warn about upgrades when image.tag is explicitly set.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
frontend/src/lib/router/index.tsx	Registers routes for the new policy and binding list/detail pages.
frontend/src/lib/k8s/validatingAdmissionPolicy.ts	Adds the `ValidatingAdmissionPolicy` KubeObject wrapper and typings.
frontend/src/lib/k8s/validatingAdmissionPolicyBinding.ts	Adds the `ValidatingAdmissionPolicyBinding` KubeObject wrapper and typings.
frontend/src/i18n/locales/en/glossary.json	Adds glossary entries for the new sidebar labels.
frontend/src/components/Sidebar/useSidebarItems.tsx	Adds sidebar items under Configuration for the new resources.
frontend/src/components/admissionpolicy/ValidatingAdmissionPolicyList.tsx	Implements the list view for policies.
frontend/src/components/admissionpolicy/ValidatingAdmissionPolicyDetails.tsx	Implements the details view for a policy (validations/constraints/etc).
frontend/src/components/admissionpolicy/ValidatingAdmissionPolicyBindingList.tsx	Implements the list view for bindings.
frontend/src/components/admissionpolicy/ValidatingAdmissionPolicyBindingDetails.tsx	Implements the details view for a binding (policy link, paramRef, matchResources).
charts/headlamp/templates/NOTES.txt	Adds a NOTES warning about pinned `image.tag` during upgrades.
charts/headlamp/README.md	Documents upgrade behavior when `image.tag` is explicitly set.

illume

Thanks for this PR.

A few of the commits don't quite follow the project guidelines. We use Linux kernel style for git commits — have a look at the contributing guide and previous commits with git log.

Commits that need attention

frontend: Add missing i18n keys for ValidatingAdmissionPolicy UI — Only one file changed inside frontend/; add a sub-area so it's clear what was touched (e.g. frontend: ComponentName: description).

Commit guidelines

Use atomic commits focused on a single change.
Use the title format <area>: <Description of changes> — description must start with a capital letter.
Keep the title under 72 characters (soft requirement).
Explain the intention and why the change is needed.
Make commit titles meaningful and describe what changed.
Do not add code that a later commit rewrites; squash or reorder commits instead.
Do not include Fixes #NN in commit messages.

Good examples:

frontend: HomeButton: Fix so it navigates to home
backend: config: Add enable-dynamic-clusters flag

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

illume

Thanks for these changes.

can you please rebase against main to remove the merge main commit?

Why this matters

Merge commits from main make the PR history harder to review. Please rebase your branch on top of the latest main instead, then update the PR with the rebased commits.

Copilot