Skip to content

fix: preserve equals signs in endpoint label values #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
immanuwell wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Open

fix: preserve equals signs in endpoint label values #6443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions endpoint/labels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,10 @@ func NewLabelsFromStringPlain(labelText string) (Labels, error) {
tokens := strings.Split(labelText, ",")
foundExternalDNSHeritage := false
for _, token := range tokens {
if len(strings.Split(token, "=")) != 2 {
key, val, ok := strings.Cut(token, "=")
if !ok {
continue
}
key := strings.Split(token, "=")[0]
val := strings.Split(token, "=")[1]
if key == "heritage" && val != heritage {
return nil, ErrInvalidHeritage
}
Expand Down
13 changes: 13 additions & 0 deletions endpoint/labels_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,19 @@ func (suite *LabelsSuite) TestDeserialize() {
suite.Nil(multipleHeritage, "if error should return nil")
}

func (suite *LabelsSuite) TestSerializeDeserializeWithEqualsInValue() {
Copy link
Copy Markdown
Member

@u-kai u-kai May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, I would prefer using table-driven tests for this file, but I think that refactor is out of scope for this PR.

Copy link
Copy Markdown
Member

@ivankatliarchuk ivankatliarchuk May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be table driven test. As we need to make sure other cases of owner still supported.

Do not use suite. Name could be TestParseLabels or of similar semantic. the current
PR's test name (TestSerializeDeserializeWithEqualsInValue) is misleading precisely because it goes through the full round-trip to avoid writing the raw string by hand, masking that the bug is purely in parsing.

labels := Labels{
"owner": "team=platform",
"resource": "ingress/default/example",
}

serialized := labels.SerializePlain(false)
parsed, err := NewLabelsFromStringPlain(serialized)

Copy link
Copy Markdown
Member

@u-kai u-kai May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for actual label texts?

suite.NoError(err)
suite.Equal(labels, parsed)
}

func TestLabels(t *testing.T) {
suite.Run(t, new(LabelsSuite))
}