fix(chart): rbac compliance checkbox for dnsendpoints/status#6442
fix(chart): rbac compliance checkbox for dnsendpoints/status#6442vflaux wants to merge 1 commit into
Conversation
Coverage Report for CI Build 26063689081Coverage remained the same at 80.638%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Silly question, but worth to make it clear. What does removing * actually protect against? Almost nothing in practice ;-). If the external-dns service account were compromised:
|
|
/retitle fix(chart): rbac compliance checkbox for dnsendpoints/status |
|
Probably /lgtm |
|
If a new verb were ever added, "*" would grant it. Afaik, that's why it's considered bad practice. |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does it do ?
Restrict RBAC permissions for
dnsendpoints/statusresource topatchandupdateverbs.Motivation
fix #6434
More