Skip to content

test(pkg/rfc2317): cover bare IPv6 and invalid-mask edge cases#6437

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
SAY-5:test/rfc2317-cover-edge-cases
May 15, 2026
Merged

test(pkg/rfc2317): cover bare IPv6 and invalid-mask edge cases#6437
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
SAY-5:test/rfc2317-cover-edge-cases

Conversation

@SAY-5
Copy link
Copy Markdown
Contributor

@SAY-5 SAY-5 commented May 13, 2026

What does it do ?

Adds three table-driven test cases to TestCidrToInAddr: bare IPv6 input (auto-appended /128), IPv4 mask not a multiple of 8, and IPv6 mask not a multiple of 4. Raises pkg/rfc2317 coverage from 86.7% to 93.3%.

Motivation

Part of #5150 (improve code coverage). Locks in the existing error/edge-case behavior of CidrToInAddr so future refactors do not silently regress these branches.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Adds table-driven cases for bare IPv6 input (auto /128), IPv4 mask
not multiple of 8, and IPv6 mask not multiple of 4. Raises package
coverage from 86.7% to 93.3%. Refs kubernetes-sigs#5150.

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @SAY-5. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the rfc2317 Issues or PRs related to rfc2317 label May 13, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2026
@k8s-ci-robot k8s-ci-robot requested a review from vflaux May 13, 2026 21:37
@mloiseleur
Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25827881005

Coverage increased (+0.02%) to 80.622%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
openshift_route.go 1 82.93%

Coverage Stats

Coverage Status
Relevant Lines: 21390
Covered Lines: 17245
Line Coverage: 80.62%
Coverage Strength: 1451.94 hits per line

💛 - Coveralls

@mloiseleur
Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@k8s-ci-robot k8s-ci-robot merged commit 3a27e8e into kubernetes-sigs:master May 15, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rfc2317 Issues or PRs related to rfc2317 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants