test(pkg/rfc2317): cover bare IPv6 and invalid-mask edge cases#6437
Conversation
Adds table-driven cases for bare IPv6 input (auto /128), IPv4 mask not multiple of 8, and IPv6 mask not multiple of 4. Raises package coverage from 86.7% to 93.3%. Refs kubernetes-sigs#5150. Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
Hi @SAY-5. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Coverage Report for CI Build 25827881005Coverage increased (+0.02%) to 80.622%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
Adds three table-driven test cases to
TestCidrToInAddr: bare IPv6 input (auto-appended /128), IPv4 mask not a multiple of 8, and IPv6 mask not a multiple of 4. Raisespkg/rfc2317coverage from 86.7% to 93.3%.Motivation
Part of #5150 (improve code coverage). Locks in the existing error/edge-case behavior of
CidrToInAddrso future refactors do not silently regress these branches.More