Skip to content

docs: add Tencent Cloud webhook provider#6432

Open
QianChenglong wants to merge 1 commit into
kubernetes-sigs:masterfrom
QianChenglong:add-tencentcloud-webhook-provider
Open

docs: add Tencent Cloud webhook provider#6432
QianChenglong wants to merge 1 commit into
kubernetes-sigs:masterfrom
QianChenglong:add-tencentcloud-webhook-provider

Conversation

@QianChenglong
Copy link
Copy Markdown

What this PR does

Why

The in-tree Tencent Cloud provider was removed per the webhook migration plan. This webhook implementation supports both DNSPod (public DNS) and PrivateDNS (VPC-scoped) with two credential modes:

  • Static: SecretId/SecretKey — works on any Kubernetes cluster
  • OIDC: TKE RRSA — keyless authentication for TKE managed clusters

References

Add Tencent Cloud (DNSPod & PrivateDNS) to the webhook provider
registry table in README.md and create a dedicated tutorial at
docs/tutorials/tencentcloud.md covering Helm installation with
both static credentials and OIDC (TKE RRSA) modes.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @QianChenglong!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @QianChenglong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2026
@mloiseleur
Copy link
Copy Markdown
Collaborator

mloiseleur commented May 12, 2026

@QianChenglong Usually, most of the webhook providers keep their tutorials on their repository. That said, I do not have a strong opinion on that, and I'm ok with that. So let's see what the other maintainers think about this.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25711968114

Coverage decreased (-0.005%) to 80.583%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
openshift_route.go 1 82.93%

Coverage Stats

Coverage Status
Relevant Lines: 21378
Covered Lines: 17227
Line Coverage: 80.58%
Coverage Strength: 1452.69 hits per line

💛 - Coveralls

@mloiseleur
Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

ivankatliarchuk commented May 16, 2026

Why we need a webhook tutorial docs/tutorials/tencentcloud.md in this repo? You could have up-to-date tutorial in the webhook repo, and keep it up to date against different external-dns versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants