feat(service): add multi-namespace support for Service source#6387
feat(service): add multi-namespace support for Service source#6387AryanSharma9917 wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @AryanSharma9917! |
|
Hi @AryanSharma9917. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add repeatable --service-namespace flag and wire it through source config.\nImplement multi-namespace informer handling in service source and add tests.\nRegenerate docs and keep full test suite green.\n\nRefs kubernetes-sigs#3565 Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
fa7b04e to
34cc378
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Instead of going down this path of having multiple namespaces array options per source, maybe we can consider extending current namespace option to allow multi namespace. It would simplify this PR, cover more use cases and won't require any additional flags. We may even in a follow up PR deprecate and after remove gloo & gateway specific namespace options. @AryanSharma9917 Wdyt ? |
Hi @mloiseleur, I think that would be a good approach, though I have a few questions before I move forward. Do you prefer a specific format like a comma separated list or an array? Also, should I start deprecating the Gloo and Gateway-specific options in this PR, or wait for the follow-up? |
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
Comma-separated list.
Deprecation in a dedicated PR, if that's ok for you ? |
@mloiseleur Thanks for confirming. That works for me. I will keep this PR focused on multi namespace support using a comma separated list and open a separate PR for deprecating the Gloo and Gateway specific namespace options. Please let me know if my understanding is correct or if I misunderstood anything. |
What this PR does
Adds multi-namespace support for the Service source by introducing repeatable
--namespacesand label-based--namespace-label-selectorfiltering.Why
This enables scoped multi-tenant deployments without requiring a separate external-dns instance per namespace.
Highlights
--namespacesand--namespace-label-selectorconfigurationFixes #3565