feat(source/gateway-api)!: migrate TLSRoute to v1

[ecray]

What does it do ?

This is migrates Gateway API TLSRoutes to version v1 as it is now fully supported in the standard channel for Gateway API 1.5.0+.

Motivation

GKE update 1.34 now blocks experimental channel CRDs from Gateway API.

Failed last sync attempt to [1.6.1 477d172e6ac5eccb82b65781ddb8f924afec4170]: one or more objects failed to apply, reason: customresourcedefinitions.apiextensions.k8s.io "tlsroutes.gateway.networking.k8s.io" is forbidden: ValidatingAdmissionPolicy 'enforce-gateway-standard-channel' with binding 'enforce-gateway-standard-channel-binding' denied request: All Gateway API CRDs must belong to the 'standard' channel. Experimental CRDs are not permitted.

Since Gateway API 1.5.0 supports TLSRoutes in standard channel, there is no reason to keep experimental channel in use.

Additional support from PR 6291 and feature request 6247.

More

• Yes, this PR title follows Conventional Commits
• Yes, I updated unit tests
• Yes, I updated end user documentation accordingly

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ecray / name: Eric Raymond (91101da)

[k8s-ci-robot]

Welcome @ecray!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ecray. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

Could you install CRD and share evidences of versions supported?

Example for istio #5611 (comment).

> kubectl get crd <api-path> -ojsonpath='{.status.storedVersions}'
and
> kubectl api-resources --api-group=.....

The feature #6247 -> RBAC misconfiguration issue from the logs.

[ecray]

The feature request is reported in 6247, but the creator of the issue is not the same as the person who reported that they are having an RBAC issue.

$ kubectl version
Client Version: v1.34.0
Kustomize Version: v5.7.1
Server Version: v1.34.4-gke.1193000

$ kubectl get crds tlsroutes.gateway.networking.k8s.io -ojsonpath='{range .spec.versions[*]}{.name}: served={.served}{"\n"}{end}'
v1: served=true
v1alpha2: served=false
v1alpha3: served=false

$ kubectl api-resources --api-group=gateway.networking.k8s.io
NAME                 SHORTNAMES   APIVERSION                          NAMESPACED   KIND
backendtlspolicies   btlspolicy   gateway.networking.k8s.io/v1        true         BackendTLSPolicy
gatewayclasses       gc           gateway.networking.k8s.io/v1        false        GatewayClass
gateways             gtw          gateway.networking.k8s.io/v1        true         Gateway
httproutes                        gateway.networking.k8s.io/v1        true         HTTPRoute
referencegrants      refgrant     gateway.networking.k8s.io/v1beta1   true         ReferenceGrant
tlsroutes                         gateway.networking.k8s.io/v1        true         TLSRoute

[ivankatliarchuk]

/ok-to-test

[ivankatliarchuk]

/retitle feat(source/gateway-api)!: migrate TLSRoute to v1

[coveralls]

Coverage Report for CI Build 24396016517

Coverage increased (+0.004%) to 80.528%

Details

• Coverage increased (+0.004%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
gateway_tlsroute.go	1	92.59%

---

Coverage Stats

Relevant Lines:	21308
Covered Lines:	17159
Line Coverage:	80.53%
Coverage Strength:	1471.35 hits per line

---

💛 - Coveralls

[ivankatliarchuk]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ivankatliarchuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mloiseleur]

/lgtm