Skip to content

fix: create/update event generation for webhook provider#6361

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
tommasopozzetti:event-emission-fix-6359
May 13, 2026
Merged

fix: create/update event generation for webhook provider#6361
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
tommasopozzetti:event-emission-fix-6359

Conversation

@tommasopozzetti
Copy link
Copy Markdown
Contributor

What does it do ?

This commit adds preservation of refObject for records around the JSON serialization and deserialization of the record objects when calling AdjustEndpoints for a webhook provider.

Motivation

Fixes: #6359

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. provider Issues or PRs related to a provider labels Apr 9, 2026
@k8s-ci-robot k8s-ci-robot requested review from szuecs and vflaux April 9, 2026 22:52
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @tommasopozzetti!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @tommasopozzetti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 10, 2026

Coverage Report for CI Build 25760544888

Coverage increased (+0.006%) to 80.594%

Details

  • Coverage increased (+0.006%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 8 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

8 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
webhook/webhook.go 7 89.11%
openshift_route.go 1 82.93%

Coverage Stats

Coverage Status
Relevant Lines: 21390
Covered Lines: 17239
Line Coverage: 80.59%
Coverage Strength: 1451.88 hits per line

💛 - Coveralls

@ivankatliarchuk
Copy link
Copy Markdown
Member

the merge commit format is not supported

Comment thread provider/webhook/webhook_test.go Outdated
This commit adds preservation of refObject for records around
the JSON serialization and deserialization of the record objects
when calling AdjustEndpoints for a webhook provider.

Signed-off-by: Tommaso <tommypozzetti@hotmail.it>
@tommasopozzetti tommasopozzetti force-pushed the event-emission-fix-6359 branch from 089233e to f008d17 Compare May 12, 2026 20:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 12, 2026
@tommasopozzetti
Copy link
Copy Markdown
Contributor Author

@ivankatliarchuk @mloiseleur Thanks, commit message should be updated and code rebased!

Copy link
Copy Markdown
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@k8s-ci-robot k8s-ci-robot merged commit 49d3f86 into kubernetes-sigs:master May 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. provider Issues or PRs related to a provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event emission doesn't work with webhook provider

5 participants