fix: create/update event generation for webhook provider#6361
Conversation
|
Welcome @tommasopozzetti! |
|
Hi @tommasopozzetti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Coverage Report for CI Build 25760544888Coverage increased (+0.006%) to 80.594%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions8 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
|
the merge commit format is not supported |
This commit adds preservation of refObject for records around the JSON serialization and deserialization of the record objects when calling AdjustEndpoints for a webhook provider. Signed-off-by: Tommaso <tommypozzetti@hotmail.it>
089233e to
f008d17
Compare
|
@ivankatliarchuk @mloiseleur Thanks, commit message should be updated and code rebased! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
This commit adds preservation of refObject for records around the JSON serialization and deserialization of the record objects when calling AdjustEndpoints for a webhook provider.
Motivation
Fixes: #6359
More