feat: add support for PTR, MX and DS record types#6336
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @castorw! |
|
Hi @castorw. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -0,0 +1,18 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
@ivankatliarchuk Can we please remove this PR? I will open another one. The source branch is fixed already. But the very unwanted file is still visible in PR.
There was a problem hiding this comment.
I do not have any maintainer or developer access to repo. I could only review/approve with the help of comment labels.
Kubernetes project is quite strict with access rights.
There was a problem hiding this comment.
Okay never mind, my bad. Here's a new one #6337.
Gonna reissue a CA now 🫤
Thanks.
What does it do ?
This PR allows use of the following record types:
Motivation
While setting up
external-dnsas provisioner for reverse zones I noticed that the controller gets in a conflict loop while trying to create records which already exist. It creates records and then in the next loop attempts to create these again. This is caused by a simple omission of allowed record types in therecordfilter.gofile. This will allow users to manage wider range of records.More