[release-1.23] test/e2e: make collectPodLogs log dump best-effort#6318
Merged
k8s-ci-robot merged 1 commit intoMay 18, 2026
Conversation
The collectPodLogs helper runs from [AfterEach] to dump pod descriptions and container logs for the workload cluster. It currently uses Expect(...).To(Succeed()) when listing pods, which turns any transient inability to reach the workload cluster API server into a hard spec failure during teardown. This is the same bug pattern that was fixed for the sibling collectNodes helper in 4a8e9f1 (kubernetes-sigs#6265). With collectNodes now returning gracefully on i/o timeout, collectPodLogs is the next call in the AfterEach log collection path and hits the same transient unreachability against *.cloudapp.azure.com:6443, causing otherwise-successful runs of the apiversion-upgrade job to fail in [AfterEach]. Match the pattern already used a few lines below for streaming container logs (and now used in collectNodes): log the error and continue instead of failing the spec. Signed-off-by: Matt Boersma <Matt.Boersma@microsoft.com>
k8s-ci-robot
added
the
release-note
4 tasks
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 2990dadbcc379a9ba1a6074230831eb5560cd7c5 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.23 #6318 +/- ##
=============================================
Coverage 43.74% 43.74%
=============================================
Files 289 289
Lines 25475 25475
=============================================
Hits 11145 11145
Misses 13527 13527
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1 |
Contributor
|
/retest Odd auth failure again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6315
/assign mboersma