Skip to content

test/e2e: make collectPodLogs log dump best-effort #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
May 18, 2026
+8 −1
Merged

test/e2e: make collectPodLogs log dump best-effort #6315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/e2e/azure_clusterproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,14 @@ func (acp *AzureClusterProxy) collectPodLogs(ctx context.Context, namespace stri
workload := acp.GetWorkloadCluster(ctx, namespace, name)
pods := &corev1.PodList{}

Expect(workload.GetClient().List(ctx, pods)).To(Succeed())
// Failing to collect pod logs should not cause the test to fail. The workload cluster
// API server may be unreachable during teardown (for example due to a transient Azure
// load balancer / DNS issue), and we should not turn an otherwise-successful spec into
// a failure during [AfterEach] log collection.
if err := workload.GetClient().List(ctx, pods); err != nil {
Logf("Failed to list pods for workload cluster %s/%s: %v", namespace, name, err)
return
}

var err error
var podDescribe string
Expand Down
Loading