Skip to content

[release-1.23] Bump CAPI to v1.12.8#6310

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.23from
mboersma:bump-capi-v1.12.8-release-1.23
May 13, 2026
Merged

[release-1.23] Bump CAPI to v1.12.8#6310
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.23from
mboersma:bump-capi-v1.12.8-release-1.23

Conversation

@mboersma
Copy link
Copy Markdown
Contributor

@mboersma mboersma commented May 13, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the Cluster API dependency to v1.12.8. Also picks up the latest patch of the previous minor line used for clusterctl-upgrade e2e tests: v1.11.11.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Brings a few Makefile knobs into sync with CAPI v1.12.8:

  • KUBEBUILDER_ENVTEST_KUBERNETES_VERSION: 1.34.0 → 1.35.0
  • GOVULNCHECK_VER: v1.1.4 → v1.3.0

Also simplifies verify-govulncheck to a single invocation with -tags=e2e ./.... The previous form was copy-pasted from CAPI and relied on an undefined TEST_DIR and a hack/tools meta-module scan that govulncheck v1.3.0 (correctly) rejects. The new form covers both the main module and the e2e-tagged test packages.

TRIVY_VER is left at 0.69.3 (newer than CAPI's 0.69.2).

Also fixes a stale Makefile reference to cluster-api-components.yaml that was missed in the previous v1.12.7 bump (it was still pointing at v1.12.5).

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Bump CAPI to v1.12.8

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 13, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2026
@mboersma mboersma force-pushed the bump-capi-v1.12.8-release-1.23 branch from 4ec23d5 to 36f5e0f Compare May 13, 2026 15:51
Comment thread Makefile

# Deploy CAPI
timeout --foreground 300 bash -c "until curl --retry $(CURL_RETRIES) -sSL https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.12.5/cluster-api-components.yaml | $(ENVSUBST) | $(KUBECTL) apply -f - --server-side=true; do sleep 5; done"
timeout --foreground 300 bash -c "until curl --retry $(CURL_RETRIES) -sSL https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.12.8/cluster-api-components.yaml | $(ENVSUBST) | $(KUBECTL) apply -f - --server-side=true; do sleep 5; done"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 766e047f7306a4f1032961103047a1d63ba0e3a7

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.74%. Comparing base (fb3a7a8) to head (36f5e0f).
⚠️ Report is 5 commits behind head on release-1.23.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.23    #6310   +/-   ##
=============================================
  Coverage         43.74%   43.74%           
=============================================
  Files               289      289           
  Lines             25475    25475           
=============================================
+ Hits              11143    11145    +2     
+ Misses            13529    13527    -2     
  Partials            803      803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mboersma
Copy link
Copy Markdown
Contributor Author

/retest

@mboersma
Copy link
Copy Markdown
Contributor Author

/test pull-cluster-api-provider-azure-e2e-v1beta1

@mboersma
Copy link
Copy Markdown
Contributor Author

/retest

@mboersma
Copy link
Copy Markdown
Contributor Author

/retest

proxy.golang.org returned 503 Service Unavailable while the Docker build was fetching sigs.k8s.io/cluster-api@v1.12.8.

@k8s-ci-robot k8s-ci-robot merged commit f9e684e into kubernetes-sigs:release-1.23 May 13, 2026
25 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in CAPZ Planning May 13, 2026
@mboersma mboersma deleted the bump-capi-v1.12.8-release-1.23 branch May 14, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants