[release-1.23] fix: propagate SERVICE_ACCOUNT_ISSUER to workload cluster template#6308
Conversation
kind-with-registry.sh creates an OIDC storage account and sets
SERVICE_ACCOUNT_ISSUER, but this value was lost when
create-workload-cluster runs envsubst in a separate shell context.
The workload cluster template has:
service-account-issuer: ${SERVICE_ACCOUNT_ISSUER:-https://kubernetes.default.svc.cluster.local}
Without the propagation, the fallback value is used, which is
unreachable by AAD for OIDC discovery, breaking Workload Identity
on CAPZ workload clusters.
Fix: persist SERVICE_ACCOUNT_ISSUER to a .env file in
kind-with-registry.sh and source it in the create-workload-cluster
Makefile target before running envsubst.
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: e8b20bd427a5f4846537c3f4690edb9105f7bb53 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.23 #6308 +/- ##
=============================================
Coverage 43.74% 43.74%
=============================================
Files 289 289
Lines 25475 25475
=============================================
+ Hits 11143 11145 +2
+ Misses 13529 13527 -2
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/override pull-cluster-api-provider-azure-e2e-workload-upgrade-v1beta1 Unrelated flake. |
|
@mboersma: Overrode contexts on behalf of mboersma: pull-cluster-api-provider-azure-e2e-workload-upgrade-v1beta1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
This is an automated cherry-pick of #6306
/assign mboersma