Skip to content

[release-1.24] fix: propagate SERVICE_ACCOUNT_ISSUER to workload cluster template#6307

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.24from
k8s-infra-cherrypick-robot:cherry-pick-6306-to-release-1.24
May 13, 2026
Merged

[release-1.24] fix: propagate SERVICE_ACCOUNT_ISSUER to workload cluster template#6307
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.24from
k8s-infra-cherrypick-robot:cherry-pick-6306-to-release-1.24

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #6306

/assign mboersma

none

kind-with-registry.sh creates an OIDC storage account and sets
SERVICE_ACCOUNT_ISSUER, but this value was lost when
create-workload-cluster runs envsubst in a separate shell context.

The workload cluster template has:
  service-account-issuer: ${SERVICE_ACCOUNT_ISSUER:-https://kubernetes.default.svc.cluster.local}

Without the propagation, the fallback value is used, which is
unreachable by AAD for OIDC discovery, breaking Workload Identity
on CAPZ workload clusters.

Fix: persist SERVICE_ACCOUNT_ISSUER to a .env file in
kind-with-registry.sh and source it in the create-workload-cluster
Makefile target before running envsubst.
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 13, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2026
Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: cc407dba14ea0da6ce8056b07d551b16517a9cbb

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.95%. Comparing base (1c00d62) to head (d87fe81).
⚠️ Report is 3 commits behind head on release-1.24.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.24    #6307   +/-   ##
=============================================
  Coverage         43.95%   43.95%           
=============================================
  Files               289      289           
  Lines             25351    25351           
=============================================
  Hits              11143    11143           
  Misses            13435    13435           
  Partials            773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot k8s-ci-robot merged commit 3ae4da7 into kubernetes-sigs:release-1.24 May 13, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in CAPZ Planning May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants