Skip to content

[release-1.23] Bump golang.org/x/net to v0.53.0#6303

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.23from
mboersma:fix-cve-golang-x-net-1.23
May 12, 2026
Merged

[release-1.23] Bump golang.org/x/net to v0.53.0#6303
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.23from
mboersma:fix-cve-golang-x-net-1.23

Conversation

@mboersma
Copy link
Copy Markdown
Contributor

@mboersma mboersma commented May 12, 2026

What this PR does / why we need it:

Fixes the Trivy / govulncheck security scan failure on release-1.23 by bumping golang.org/x/net from v0.52.0 to v0.53.0.

The scan reports a single vulnerability on this branch:

GO-2026-4918: Infinite loop in HTTP/2 transport when given bad SETTINGS_MAX_FRAME_SIZE in net/http/internal/http2 in golang.org/x/net.
Found in: golang.org/x/net@v0.52.0
Fixed in: golang.org/x/net@v0.53.0
More info: https://pkg.go.dev/vuln/GO-2026-4918

The traces show the vulnerable code is reachable via azure.CustomPutPatchHeaderPolicy.Doexported.Request.Nexthttp2.Transport.RoundTrip (and variants), so this is not a false positive.

Which issue(s) this PR fixes:

Fixes the failing Trivy (release-1.23) job in https://github.com/kubernetes-sigs/cluster-api-provider-azure/actions/runs/25745708187/job/75608228241

Special notes for your reviewer:

Generated with go get golang.org/x/net@v0.53.0 && go mod tidy. The MVS resolution also pulled in compatible minor bumps to other golang.org/x/* modules (x/crypto, x/mod, x/sys, x/term, x/text, x/tools). go build ./... and govulncheck ./... both pass locally.

Release note:

NONE

GO-2026-4918: Infinite loop in HTTP/2 transport when given bad
SETTINGS_MAX_FRAME_SIZE in net/http/internal/http2 in golang.org/x/net.
Fixed in golang.org/x/net v0.53.0.

Ran 'go get golang.org/x/net@v0.53.0 && go mod tidy', which also
brought along transitive bumps to x/crypto, x/mod, x/sys, x/term,
x/text, and x/tools.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 12, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2026
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 12, 2026
@mboersma mboersma changed the title [release-1.23] Bump golang.org/x/net to v0.53.0 to address GO-2026-4918 [release-1.23] Bump golang.org/x/net to v0.53.0 May 12, 2026
@mboersma mboersma requested review from jackfrancis and willie-yao and removed request for jsturtevant May 12, 2026 16:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.74%. Comparing base (eee3bfd) to head (fb3a7a8).
⚠️ Report is 1 commits behind head on release-1.23.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.23    #6303      +/-   ##
================================================
- Coverage         43.74%   43.74%   -0.01%     
================================================
  Files               289      289              
  Lines             25475    25475              
================================================
- Hits              11145    11143       -2     
- Misses            13527    13529       +2     
  Partials            803      803              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willie-yao
Copy link
Copy Markdown
Contributor

/retest

Copy link
Copy Markdown
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 9c62c65c30299e2ba67660950e1d2c854fbf2cd0

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4111602 into kubernetes-sigs:release-1.23 May 12, 2026
26 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in CAPZ Planning May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants