[release-1.24] fix: configure service-account-issuer in prow CI cluster templates#6290
Merged
k8s-ci-robot merged 2 commits intoMay 8, 2026
Conversation
Set service-account-issuer: ${SERVICE_ACCOUNT_ISSUER} in the base
cluster template (templates/flavors/base/cluster-template.yaml).
This ensures projected service account tokens are signed with a
discoverable issuer URL. The default value falls back to the
kube-apiserver default (https://kubernetes.default.svc.cluster.local),
so existing deployments are unaffected.
When SERVICE_ACCOUNT_ISSUER is set (e.g., to a public OIDC endpoint),
workload identity flows (CSI drivers, pod identity) will work correctly
because AAD can discover and validate the token issuer.
/kind bug
Clarify that if SERVICE_ACCOUNT_ISSUER is unset, kubeadm defaults to https://kubernetes.default.svc.cluster.local, and explain when users should set it to their Azure storage container URL.
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/L
mboersma
approved these changes
May 8, 2026
Contributor
mboersma
left a comment
mboersma
left a comment
There was a problem hiding this comment.
/label tide/merge-method-squash
/lgtm
/approve
k8s-ci-robot
added
tide/merge-method-squash
Contributor
|
LGTM label has been added. DetailsGit tree hash: b4fc423c60affe887298f98eafc68ed57bb26d62 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.24 #6290 +/- ##
=============================================
Coverage 43.94% 43.95%
=============================================
Files 289 289
Lines 25351 25351
=============================================
+ Hits 11141 11143 +2
+ Misses 13437 13435 -2
Partials 773 773 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6288
/assign mboersma