Remove stale CRDs and add missing ASO managed kinds to PROJECT#6285
Merged
k8s-ci-robot merged 1 commit intoMay 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6285 +/- ##
=======================================
Coverage 43.94% 43.95%
=======================================
Files 289 289
Lines 25351 25351
=======================================
+ Hits 11141 11143 +2
+ Misses 13437 13435 -2
Partials 773 773 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM label has been added. DetailsGit tree hash: feb27e0f53dc76dea2c80935a5e79ede49e28326 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Cleans up two pieces of generated-output drift in
config/crd/bases/andPROJECT:Deletes three orphaned CRD files left over from old
v1alpha3types that no longer exist in code (thecontroller-gen.kubebuilder.io/version: v0.3.0annotation and the typo'd pluralidentitesare giveaways):infrastructure.cluster.x-k8s.io_azureserviceprincipals.yamlinfrastructure.cluster.x-k8s.io_azuresystemassignedidentites.yamlinfrastructure.cluster.x-k8s.io_azureuserassignedidentites.yamlNo matching Go types exist (
grep -r AzureServicePrincipal --include="*.go"returns nothing) andconfig/crd/kustomization.yamldoesn't reference them — they're not in the build, just sitting in the tree.controller-gendoesn't delete stale files, so they have to go manually.Appends the six
AzureASOManaged*kinds toPROJECT. They were missed when the ASO-managed types were added but they have+kubebuilder:object:root=truemarkers and CRDs inconfig/crd/bases/.make generateproduces no further drift on a clean tree after this change.Which issue(s) this PR fixes:
This narrows the scope of #5391. Posting a separate comment on the issue suggesting the larger "make
kubebuilder create apiwork end-to-end" goal isn't worth pursuing given CAPZ has intentionally diverged from kubebuilder scaffolding (e.g.internal/webhooks/layout from #6141 and #6280).Special notes for your reviewer:
None.
TODOs:
Release note: