Strip OpenAPI description fields from vendored ASO CRDs#6281
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6281 +/- ##
=======================================
Coverage 43.95% 43.95%
=======================================
Files 289 289
Lines 25351 25351
=======================================
Hits 11143 11143
Misses 13435 13435
Partials 773 773 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test pull-cluster-api-provider-azure-aks-mgmt-e2e |
willie-yao
left a comment
There was a problem hiding this comment.
Thanks for this! I've been running into issues in Tilt because of the files being too large
/lgtm
/approve
|
LGTM label has been added. DetailsGit tree hash: 5cfcf281542bc16bf2904bdd2cba6fca5c624142 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The vendored
managedclusters.containerservice.azure.comASO CRD is ~2.35 MB serialized, which exceeds the request-size / streaming-timeout budgets enforced by some Kubernetes API servers — notably EKS. As a result,clusterctl init -i azureagainst an EKS management cluster times out repeatedly trying to apply that single CRD and ultimately fails after the 10 retry attempts.This PR adds a
yqstep tomake generate-aso-crdsthat strips OpenAPIdescriptionfields from the schemas before writingconfig/aso/crds.yaml:Verified impact:
managedclustersCRDconfig/aso/crds.yamldescriptionis pure metadata in OpenAPI v3 schemas, so this does not affect validation. The only loss is the inline doc text shown bykubectl explain; ASO publishes the same docs externally.All 10 served
spec.versionsof every CRD are preserved, so ASO's conversion webhook compatibility is unaffected.Which issue(s) this PR fixes:
Fixes #6080
Special notes for your reviewer:
The bulk of the diff is the regenerated
config/aso/crds.yaml(-23 850 lines). Only the Makefile change is human-authored.This is the smallest, lowest-risk fix. Two follow-up tracks worth pursuing separately:
TODOs:
Release note: