Add Private Link support#6274
Conversation
Co-authored-by: Nikola Prokopić <nikola@prokopic.rs> Signed-off-by: Robin Ketelbuters <robin.k@giantswarm.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @robinkb! |
|
Hi @robinkb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test Thanks for reviving this :) FYI stale bot closed the issue #3400, probably a good idea to check with CAPZ folks if the issue should be reopened. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6274 +/- ##
==========================================
- Coverage 43.88% 43.64% -0.24%
==========================================
Files 289 293 +4
Lines 25351 26077 +726
==========================================
+ Hits 11125 11382 +257
- Misses 13448 13904 +456
- Partials 778 791 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
From: #3747 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3400
Special notes for your reviewer:
This PR was originally submitted in #3747, but unfortunately it got stalled due to time constraints. I have gone through the comments in the original PR, and applied what still seemed relevant to the revision in this PR. Special thanks to @nprokopic for development of the feature.
TODOs:
Release note: