[release-1.22] test/e2e: make collectNodes log dump best-effort#6267
Merged
k8s-ci-robot merged 2 commits intoMay 2, 2026
Conversation
The collectNodes helper runs from [AfterEach] to dump per-node logs and descriptions for the workload cluster. It currently uses Expect(...).To(Succeed()) when listing nodes, which turns any transient inability to reach the workload cluster API server into a hard spec failure during teardown. In practice the workload cluster's Azure load balancer / API server is sometimes briefly unreachable while the spec is being torn down, which has been causing otherwise-successful runs of the apiversion-upgrade job to fail in [AfterEach] with i/o timeout against *.cloudapp.azure.com:6443. Match the pattern already used a few lines above for streaming pod logs: log the error and continue instead of failing the spec. Signed-off-by: Matt Boersma <Matt.Boersma@microsoft.com>
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.22 #6267 +/- ##
=============================================
Coverage 44.49% 44.49%
=============================================
Files 280 280
Lines 25357 25357
=============================================
Hits 11282 11282
Misses 13261 13261
Partials 814 814 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 14fb3efe47c929fa5e79184cfc3e254fee7ae5c3 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6265
/assign mboersma