Skip to content

test/e2e: make collectNodes log dump best-effort #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
May 2, 2026
Merged

test/e2e: make collectNodes log dump best-effort #6265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4edea0
Add xtrace debugging
mboersma Oct 2, 2025
4a8e9f1
test/e2e: make collectNodes log dump best-effort
mboersma May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hack/version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ set -o errexit
set -o nounset
set -o pipefail

set -o xtrace

version::get_version_vars() {
# shellcheck disable=SC1083
GIT_COMMIT="$(git rev-parse HEAD^{commit})"
Expand Down Expand Up @@ -96,4 +98,4 @@ version::ldflags() {
echo "${ldflags[*]-}"
}

version::ldflags
version::ldflags
9 changes: 8 additions & 1 deletion test/e2e/azure_clusterproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,14 @@ func (acp *AzureClusterProxy) collectNodes(ctx context.Context, namespace string
workload := acp.GetWorkloadCluster(ctx, namespace, name)
nodes := &corev1.NodeList{}

Expect(workload.GetClient().List(ctx, nodes)).To(Succeed())
// Failing to collect node logs should not cause the test to fail. The workload cluster
// API server may be unreachable during teardown (for example due to a transient Azure
// load balancer / DNS issue), and we should not turn an otherwise-successful spec into
// a failure during [AfterEach] log collection.
if err := workload.GetClient().List(ctx, nodes); err != nil {
Logf("Failed to list nodes for workload cluster %s/%s: %v", namespace, name, err)
return
}

var err error
var nodeDescribe string
Expand Down
Loading