Add AKS E2E scenario for maintenance configurations via ASO#6264
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6264 +/- ##
=======================================
Coverage 43.88% 43.88%
=======================================
Files 289 289
Lines 25351 25351
=======================================
Hits 11125 11125
Misses 13448 13448
Partials 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
92971e8 to
8adbd8f
Compare
Signed-off-by: William Yao <william2000yao@gmail.com>
8adbd8f to
61484a9
Compare
|
/assign @jackfrancis @mboersma |
mboersma
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Nice work!
| decorder | ||
| overriden | ||
| wit | ||
| ist |
There was a problem hiding this comment.
Is this for MaintenanceList?
There was a problem hiding this comment.
It was due to the MaintenanceConfiguration CRD which had this docstring: UtcOffset: The UTC offset in format +/-HH:mm. For example, '+05:30' for IST and '-07:00' for PST.
|
LGTM label has been added. DetailsGit tree hash: 643212cb08f09debda80c61f5944796ef0e094eb |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@willie-yao: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a scenario to the AKS E2E test for testing maintenance configurations via ASO, as well as a template for Tilt to demonstrate the feature.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: