Skip to content

Add AKS E2E scenario for maintenance configurations via ASO#6264

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
willie-yao:maintenance-config
May 6, 2026
Merged

Add AKS E2E scenario for maintenance configurations via ASO#6264
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
willie-yao:maintenance-config

Conversation

@willie-yao
Copy link
Copy Markdown
Contributor

@willie-yao willie-yao commented May 1, 2026

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a scenario to the AKS E2E test for testing maintenance configurations via ASO, as well as a template for Tilt to demonstrate the feature.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 1, 2026
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2026
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.88%. Comparing base (d328b5f) to head (61484a9).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6264   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files         289      289           
  Lines       25351    25351           
=======================================
  Hits        11125    11125           
  Misses      13448    13448           
  Partials      778      778           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willie-yao willie-yao force-pushed the maintenance-config branch 2 times, most recently from 92971e8 to 8adbd8f Compare May 4, 2026 17:13
@willie-yao willie-yao changed the title WIP: Add E2E test for AKS maintenance configurations via ASO Add E2E test for AKS maintenance configurations via ASO May 4, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2026
@willie-yao willie-yao changed the title Add E2E test for AKS maintenance configurations via ASO Add AKS E2E scenario for maintenance configurations via ASO May 4, 2026
Signed-off-by: William Yao <william2000yao@gmail.com>
@willie-yao willie-yao force-pushed the maintenance-config branch from 8adbd8f to 61484a9 Compare May 4, 2026 20:57
@willie-yao
Copy link
Copy Markdown
Contributor Author

/assign @jackfrancis @mboersma

Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Nice work!

Comment thread .codespellignore
decorder
overriden
wit
ist
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for MaintenanceList?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was due to the MaintenanceConfiguration CRD which had this docstring: UtcOffset: The UTC offset in format +/-HH:mm. For example, '+05:30' for IST and '-07:00' for PST.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 643212cb08f09debda80c61f5944796ef0e094eb

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@willie-yao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e 61484a9 link unknown /test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@willie-yao
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit bc2565d into kubernetes-sigs:main May 6, 2026
20 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone May 6, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in CAPZ Planning May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants