Remove fake FakeClient#6263
Merged
Merged
Conversation
controller-runtime implemented server-side apply in the fake client. Our tests worked around its absence by wrapping it in our own FakeClient with some light-touch logic to make sure that an apply was invoked. Now, the fake client produces the expected side effects where we can GET the applied objects and inspect them directly. This produces simpler and more robust tests.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6263 +/- ##
=======================================
Coverage 43.88% 43.88%
=======================================
Files 289 289
Lines 25351 25351
=======================================
Hits 11125 11125
Misses 13448 13448
Partials 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: ec09f58a7f4c061926a5f4125b453d406e51e28b |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
controller-runtime implemented server-side apply in the fake client. Our tests worked around its absence by wrapping it in our own FakeClient with some light-touch logic to make sure that an apply was invoked. Now, the fake client produces the expected side effects where we can GET the applied objects and inspect them directly. This produces simpler and more robust tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: