Dalec E2E: Use upstream k8s images if no artifacts are built#6258
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
size/L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6258 +/- ##
==========================================
+ Coverage 43.85% 43.88% +0.03%
==========================================
Files 289 289
Lines 25341 25351 +10
==========================================
+ Hits 11113 11125 +12
+ Misses 13450 13448 -2
Partials 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mboersma
left a comment
mboersma
left a comment
There was a problem hiding this comment.
lgtm, my only real concern is it contains 30 lines of code that is duplicated twice (with one variant). Is it possible to have just one patch file?
| # Download all binaries to temp files first, then replace | ||
| ALL_UPSTREAM_BINARIES=("kubeadm" "kubectl" "kubelet") | ||
| for BINARY in "$${ALL_UPSTREAM_BINARIES[@]}"; do | ||
| TEMP_FILE="/tmp/$${BINARY}.download" |
There was a problem hiding this comment.
It doesn't really matter in this context, but mktemp can be more portable than hardcoding /tmp.
Some of the scripts differ very slightly between distros and control planes / machine deployments have different paths, so I don't think it's trivial to do this with just a single patch file. It could be something to look into as a follow-up though! |
Signed-off-by: William Yao <william2000yao@gmail.com>
willie-yao
force-pushed
the
fix-dalec-substitution
branch
from
36ae260 to
97a294b
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 1e332440ff6cf8fa9af6923a5040b0bb16289aa0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.22 |
|
@willie-yao: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.23 |
|
@willie-yao: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@willie-yao: new pull request created: #6259 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@willie-yao: new pull request created: #6260 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR accounts for an edge case where a Dalec test is only testing images and a CAPZ community gallery image does not yet exist for that version, the artifacts are set to the wrong version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: