Skip to content

Add multi zone template for Cloud Provider Azure CI#6252

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
willie-yao:fix-multi-zone-test
Apr 27, 2026
Merged

Add multi zone template for Cloud Provider Azure CI#6252
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
willie-yao:fix-multi-zone-test

Conversation

@willie-yao
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This PR adds a newer version of the multi zone vmss template from cloud provider azure with improvements in an attempt to fix the test. It was removed in kubernetes/test-infra#36242 for being broken

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-sigs/cloud-provider-azure#9863

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

Signed-off-by: William Yao <william2000yao@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Apr 22, 2026
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.25%. Comparing base (dc8aba1) to head (e9c0a3a).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6252      +/-   ##
==========================================
+ Coverage   43.85%   46.25%   +2.40%     
==========================================
  Files         289      289              
  Lines       25341    29951    +4610     
==========================================
+ Hits        11113    13854    +2741     
- Misses      13450    15319    +1869     
  Partials      778      778              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I have two comments:

  • it assumes 3 availability zones, which isn't true for all Azure regions. So it's on the consumer (cloud-provider-azure) to deploy this only in comptible regions. Just sayin'.
  • It's not used by CAPZ itself. So as we've seen before (with the Windows templates in particular), it can rust and become broken if downstream consumers don't actively use it and effectively help us maintain it.

It sounds like you're aware of these tradeoffs and decided it was still preferable to have it in CAPZ, correct?

@willie-yao
Copy link
Copy Markdown
Contributor Author

@mboersma Thanks for the review! I did consider both of these. I verified that all the locations we use in CI had three availability zones. Also, the template is based mostly on the machine pool ci version template with just the availability zone patched in, so there shouldn't be issues unless more needs to be added. Cloud provider azure also uses the CAPZ template for cloud-provider-azure-conformance-vmss-capz https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml#L1560

Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @jackfrancis

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f9e50c90f88bdc1dfebb30963259c9e4bd5aedb9

Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@mboersma
Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit e0e956f into kubernetes-sigs:main Apr 27, 2026
29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 27, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in CAPZ Planning Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add E2E test coverage for Multi-Zone VMSS

4 participants