[WIP] Upgrade CAPI to v1.10.0-rc.0#5563
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
==========================================
- Coverage 52.86% 52.83% -0.04%
==========================================
Files 272 272
Lines 29474 29502 +28
==========================================
+ Hits 15582 15587 +5
- Misses 13080 13103 +23
Partials 812 812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
373647f to
9722c3a
Compare
|
A better error than earlier panic: input.KubeConfigPath is required for DumpAllResources
Expected
<string>:
not to be empty
goroutine 1 [running]:
main.Fail({0xc00055ec60?, 0xc000736fc0?}, {0x7983fe0?, 0xc00108c630?, 0x4c7bf40?})
/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/logger.go:39 +0x27
github.com/onsi/gomega/internal.(*Assertion).match(0xc000e9e500, {0x576f648, 0x7980860}, 0x0, {0xc000eb3790, 0x1, 0x1})
/home/prow/go/pkg/mod/github.com/onsi/gomega@v1.36.3/internal/assertion.go:106 +0x1f0
github.com/onsi/gomega/internal.(*Assertion).NotTo(0xc000e9e500, {0x576f648, 0x7980860}, {0xc000eb3790, 0x1, 0x1})
/home/prow/go/pkg/mod/github.com/onsi/gomega@v1.36.3/internal/assertion.go:74 +0xad
sigs.k8s.io/cluster-api/test/framework.DumpAllResources({0x5788d70, 0x7980860}, {{0x7fe1bc396a90, 0xc000e14900}, {0x0, 0x0}, {0x0, 0x0}, {0x7fff5e82b281, 0x7}, ...})
/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.10.0-beta.1/framework/alltypes_helpers.go:132 +0x1c3
main.collectManagementClusterLogs(0xc0003fc2b0, {0xc000635320, 0x2e}, 0xc000365520, {0xc0006352f0, 0x2c})
/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/logger.go:96 +0x38a
main.main()
/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/logger.go:78 +0x5f7 |
9722c3a to
13cc7d7
Compare
13cc7d7 to
e3c1ffd
Compare
|
@nawazkh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing this PR in favor of #5517 |
|
@nawazkh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: