Skip to content

fix: update generate-release-note script#10350

Merged
nilo19 merged 2 commits into
kubernetes-sigs:masterfrom
anndono:chengan/fix-generate-release-note-script
May 18, 2026
Merged

fix: update generate-release-note script#10350
nilo19 merged 2 commits into
kubernetes-sigs:masterfrom
anndono:chengan/fix-generate-release-note-script

Conversation

@anndono
Copy link
Copy Markdown
Contributor

@anndono anndono commented May 15, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR updates generate-release-note.sh to use the current release-notes CLI interface.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 15, 2026
@github-actions github-actions Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 15, 2026
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and nilo19 May 15, 2026 05:08
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2026
@anndono anndono mentioned this pull request May 15, 2026
Merged
Liunardy
Liunardy approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Liunardy Liunardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anndono, Liunardy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

@anndono: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-capz 9c36cdf link true /test pull-cloud-provider-azure-e2e-capz
pull-cloud-provider-azure-e2e-ccm-vmss-capz 9c36cdf link true /test pull-cloud-provider-azure-e2e-ccm-vmss-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@anndono anndono mentioned this pull request May 18, 2026
Merged
@nilo19
Copy link
Copy Markdown
Contributor

nilo19 commented May 18, 2026

/lgtm

@nilo19 nilo19 merged commit ce0c4f3 into kubernetes-sigs:master May 18, 2026
7 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
Liunardy
Liunardy reviewed May 18, 2026
View reviewed changes
Comment thread hack/generate-release-note.sh
Comment on lines 20 to 27
install_cli() {
export PATH="$(go env GOPATH)/bin:${PATH}"
if ! [[ -x "$(command -v release-notes)" ]]; then
echo "CLI release-notes not found, installing..."
GO111MODULE=on go install k8s.io/release/cmd/release-notes@latest
GO111MODULE=on go install k8s.io/release/cmd/release-notes@v0.21.1
else
echo "CLI release-notes found, skip installing. If you want to upgrade, run 'GO111MODULE=on go install k8s.io/release/cmd/release-notes@latest'"
fi
Copy link
Copy Markdown
Contributor

@Liunardy Liunardy May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only installs if the binary isn't already found on PATH. If a release-notes binary already exists (any version), it skips the install entirely and uses whatever version is present. Since version is pinned, we should always use the pinned version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liunardy Liunardy Liunardy approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@nilo19 nilo19

@Liunardy Liunardy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anndono @k8s-ci-robot @nilo19 @Liunardy