Skip to content

feature: add env variables for Kubernetes service#10188

Open
MehdiRtal wants to merge 2 commits into
kubernetes-sigs:masterfrom
MehdiRtal:master
Open

feature: add env variables for Kubernetes service#10188
MehdiRtal wants to merge 2 commits into
kubernetes-sigs:masterfrom
MehdiRtal:master

Conversation

@MehdiRtal
Copy link
Copy Markdown

What type of PR is this?

/kind feature

What this PR does / why we need it:

The Problem: When a Pod is running in hostNetwork: true mode, it inherits the network namespace of the host. By default, Kubernetes injects KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT pointing to the internal ClusterIP of the API server. In certain Azure networking topologies (or when using specific local proxies), these default values can be unreachable or conflict with host-level services.

The Fix: This PR introduces the ability to specify custom values for these variables. This ensures that host-networked components (like the Azure Cloud Controller Manager or Node-level agents) can reliably reach the API server via a specific endpoint (e.g., a Load Balancer IP or localhost) rather than the default ClusterIP.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allows overriding KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT for components running in hostNetwork mode to improve connectivity in complex Azure networking environments.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2026
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 15, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @MehdiRtal!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 15, 2026
@github-actions github-actions Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 15, 2026
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer April 15, 2026 08:31
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2026
@k8s-ci-robot k8s-ci-robot requested a review from mboersma April 15, 2026 08:31
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @MehdiRtal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MehdiRtal
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 15, 2026
@nilo19 nilo19 requested a review from Copilot May 7, 2026 00:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Helm chart for cloud-provider-azure to allow overriding the KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT environment variables, primarily to improve API server connectivity for components running with hostNetwork: true in certain Azure networking topologies.

Changes:

  • Add new Helm values to configure custom Kubernetes service host/port.
  • Inject KUBERNETES_SERVICE_HOST / KUBERNETES_SERVICE_PORT into the CCM and CNM (Linux + Windows) pod specs when configured.
  • Regenerate the Helm repo index.yaml to include the updated chart package metadata.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
helm/repo/index.yaml Updates chart index metadata (timestamps/digest) for the newly packaged chart.
helm/cloud-provider-azure/values.yaml Introduces new configurable values for Kubernetes service host/port overrides.
helm/cloud-provider-azure/templates/cloud-provider-azure.yaml Adds conditional env-var injection into CCM/CNM workloads based on the new values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +305 to +306
env:
{{- if .Values.k8sServiceHost }}
Comment on lines +306 to +310
{{- if .Values.k8sServiceHost }}
- name: KUBERNETES_SERVICE_HOST
value: "{{ .Values.k8sServiceHost }}"
{{- end }}
{{- if .Values.k8sServicePort }}
Comment on lines +86 to +87
k8sServiceHost: ""
k8sServicePort: ""
@nilo19
Copy link
Copy Markdown
Contributor

nilo19 commented May 7, 2026

@mboersma what do you think of this change?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants