fix: stop ticker/timer in waitForMount to avoid leak

[dimbleby]

What type of PR is this?
/kind bug

What this PR does / why we need it:

waitForMount used time.Tick and time.After. time.Tick's underlying ticker is never garbage collected per the Go documentation, so every blobfuse mount leaked a runtime ticker that kept firing after the function returned. On the timeout path the ticker would continue to tick forever.

Use time.NewTicker and time.NewTimer with deferred Stop so resources are released when the function returns.

Which issue(s) this PR fixes:

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dimbleby / name: David Hotham (dfc6c3a)

[k8s-ci-robot]

Welcome @dimbleby!

It looks like this is your first PR to kubernetes-sigs/blob-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blob-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dimbleby. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

Fixes a runtime resource leak in waitForMount by replacing time.Tick/time.After (which prevent the underlying ticker/timer from being garbage-collected) with time.NewTicker/time.NewTimer paired with deferred Stop() calls.

Changes:

• Replace time.Tick(intervel) with time.NewTicker + defer ticker.Stop().
• Replace time.After(timeout) with time.NewTimer + defer timer.Stop().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[andyzhangx]

/ok-to-test

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, dimbleby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/cherrypick release-1.27

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #2471

Details

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.