Skip to content

deprecate allow-inline-volume-key-access-with-identity flag (no-op) #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srranjan-sri wants to merge 1 commit into
base: master
Choose a base branch
from
Open

deprecate allow-inline-volume-key-access-with-identity flag (no-op) #3148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ The following table lists the configurable parameters of the latest Azure File C
| `node.cloudConfigSecretName` | cloud config secret name of node driver | `azure-cloud-provider`
| `node.cloudConfigSecretNamespace` | cloud config secret namespace of node driver | `kube-system`
| `node.allowEmptyCloudConfig` | Whether allow running node driver without cloud config | `true`
| `node.allowInlineVolumeKeyAccessWithIdentity` | Whether allow accessing storage account key using cluster identity for inline volume | `false`
| `node.allowInlineVolumeKeyAccessWithIdentity` | **DEPRECATED**: no-op, will be removed in a future release. Inline volumes no longer support identity-based key access. | `false`
| `node.maxUnavailable` | `maxUnavailable` value of driver node daemonset | `1`
| `node.livenessProbe.healthPort ` | health check port for liveness probe | `29613` |
| `node.nodeDriverRegistrar.healthPort` | health check port for node-driver-registrar liveness probe | `29617` |
Expand Down
Binary file modified charts/latest/azurefile-csi-driver-v0.0.0.tgz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion charts/latest/azurefile-csi-driver/templates/csi-azurefile-node-windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ spec:
- "--user-agent-suffix={{ .Values.driver.userAgentSuffix }}"
- "--allow-empty-cloud-config={{ .Values.node.allowEmptyCloudConfig }}"
- "--enable-get-volume-stats={{ .Values.feature.enableGetVolumeStats }}"
- "--allow-inline-volume-key-access-with-identity={{ .Values.node.allowInlineVolumeKeyAccessWithIdentity }}"
- "--allow-inline-volume-key-access-with-identity={{ .Values.node.allowInlineVolumeKeyAccessWithIdentity }}" # DEPRECATED: no-op, will be removed in a future release
Copy link
Copy Markdown

@landreasyan landreasyan May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the no-op since the functionality stays for the next 2 or so releases.

- "--metrics-address=0.0.0.0:{{ .Values.node.metricsPort }}"
ports:
- containerPort: {{ .Values.node.livenessProbe.healthPort }}
Expand Down
2 changes: 1 addition & 1 deletion charts/latest/azurefile-csi-driver/templates/csi-azurefile-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ spec:
- "--enable-volume-mount-group={{ .Values.feature.enableVolumeMountGroup }}"
- "--enable-get-volume-stats={{ .Values.feature.enableGetVolumeStats }}"
- "--mount-permissions={{ .Values.linux.mountPermissions }}"
- "--allow-inline-volume-key-access-with-identity={{ .Values.node.allowInlineVolumeKeyAccessWithIdentity }}"
- "--allow-inline-volume-key-access-with-identity={{ .Values.node.allowInlineVolumeKeyAccessWithIdentity }}" # DEPRECATED: no-op, will be removed in a future release
- "--metrics-address=0.0.0.0:{{ .Values.node.metricsPort }}"
- "--enable-kata-cc-mount={{ .Values.node.enableKataCCMount }}"
livenessProbe:
Expand Down
2 changes: 1 addition & 1 deletion charts/latest/azurefile-csi-driver/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ node:
cloudConfigSecretName: azure-cloud-provider
cloudConfigSecretNamespace: kube-system
allowEmptyCloudConfig: true
allowInlineVolumeKeyAccessWithIdentity: false
allowInlineVolumeKeyAccessWithIdentity: false # DEPRECATED: no-op, will be removed in a future release
enableKataCCMount: false
enableManagedIdentityAuth: true
metricsPort: 29615
Expand Down
3 changes: 3 additions & 0 deletions pkg/azurefile/azurefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,9 @@ func NewDriver(options *DriverOptions) *Driver {
driver.userAgentSuffix = options.UserAgentSuffix
driver.allowEmptyCloudConfig = options.AllowEmptyCloudConfig
driver.allowInlineVolumeKeyAccessWithIdentity = options.AllowInlineVolumeKeyAccessWithIdentity
Comment thread
srranjan-sri marked this conversation as resolved.
if options.AllowInlineVolumeKeyAccessWithIdentity {
klog.Warning("allow-inline-volume-key-access-with-identity is deprecated and has no effect; inline volumes no longer support identity-based key access")
}
driver.enableVHDDiskFeature = options.EnableVHDDiskFeature
driver.enableVolumeMountGroup = options.EnableVolumeMountGroup
driver.enableGetVolumeStats = options.EnableGetVolumeStats
Expand Down
2 changes: 1 addition & 1 deletion pkg/azurefile/azurefile_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (o *DriverOptions) AddFlags() *flag.FlagSet {
fs.StringVar(&o.CustomUserAgent, "custom-user-agent", "", "custom userAgent")
fs.StringVar(&o.UserAgentSuffix, "user-agent-suffix", "", "userAgent suffix")
fs.BoolVar(&o.AllowEmptyCloudConfig, "allow-empty-cloud-config", true, "allow running driver without cloud config")
fs.BoolVar(&o.AllowInlineVolumeKeyAccessWithIdentity, "allow-inline-volume-key-access-with-identity", false, "allow accessing storage account key using cluster identity for inline volume")
fs.BoolVar(&o.AllowInlineVolumeKeyAccessWithIdentity, "allow-inline-volume-key-access-with-identity", false, "DEPRECATED: this flag is a no-op and will be removed in a future release. Inline volumes no longer support identity-based key access.")
fs.BoolVar(&o.EnableVHDDiskFeature, "enable-vhd", true, "enable VHD disk feature (experimental)")
fs.BoolVar(&o.EnableVolumeMountGroup, "enable-volume-mount-group", true, "indicates whether enabling VOLUME_MOUNT_GROUP")
fs.BoolVar(&o.EnableGetVolumeStats, "enable-get-volume-stats", true, "allow GET_VOLUME_STATS on agent node")
Expand Down