Skip to content

Fix error when updating health check settings in TGC for Gateway API ALB target groups#4741

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
shraddhabang:hcBugFix
May 18, 2026
Merged

Fix error when updating health check settings in TGC for Gateway API ALB target groups#4741
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
shraddhabang:hcBugFix

Conversation

@shraddhabang
Copy link
Copy Markdown
Collaborator

Issue

#4740

Description

Two bugs in isSDKTargetGroupRequiresReplacementDueToNLBHealthCheck:

  1. isL4TargetGroup switch had empty case bodies that did not fall through (Go semantics), so only TCP_UDP returned true
  2. Guard logic was inverted — skipped replacement for NLB and forced replacement for ALB

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot requested review from oliviassss and shuqz May 15, 2026 21:26
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.24%. Comparing base (22cdb42) to head (5f7d397).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
+ Coverage   56.09%   56.24%   +0.14%     
==========================================
  Files         388      390       +2     
  Lines       30932    31040     +108     
==========================================
+ Hits        17352    17459     +107     
- Misses      12566    12570       +4     
+ Partials     1014     1011       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@zac-nixon zac-nixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shraddhabang, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [shraddhabang,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shuqz
Copy link
Copy Markdown
Collaborator

shuqz commented May 18, 2026

/approved

@k8s-ci-robot k8s-ci-robot merged commit 16add29 into kubernetes-sigs:main May 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants