[feat i2g]setup e2e test for migration tool#4739
Open
shuqz wants to merge 2 commits into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shuqz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4739 +/- ##
==========================================
+ Coverage 56.09% 56.23% +0.13%
==========================================
Files 388 389 +1
Lines 30932 31043 +111
==========================================
+ Hits 17352 17456 +104
- Misses 12566 12575 +9
+ Partials 1014 1012 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
and verifies the ingress ALB serves traffic correctly
lbc-migrate --dry-run, applies generated manifests, verifies thegateway.k8s.aws/dry-runannotation prevents ALB creation, and validates the dry-run plan annotation- Listener ports and protocols
- Listener rules compared in priority order; conditions within each rule matched by field type
- Target group count and types
- Tags on LB, listener rules, and target groups (user tags + migrated-from tag)
- Default rule action types
LoadBalancerConfiguration, TargetGroupConfiguration, and ListenerRuleConfiguration resources are created
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯