Skip to content

feat(gateway): implement validation and status tracking for TargetGroupConfiguration#4731

Open
Nithin0620 wants to merge 2 commits into
kubernetes-sigs:mainfrom
Nithin0620:feat/tgc-api-improvements
Open

feat(gateway): implement validation and status tracking for TargetGroupConfiguration#4731
Nithin0620 wants to merge 2 commits into
kubernetes-sigs:mainfrom
Nithin0620:feat/tgc-api-improvements

Conversation

@Nithin0620
Copy link
Copy Markdown

@Nithin0620 Nithin0620 commented May 9, 2026

PR Title:

feat(gateway): implement validation and status tracking for TargetGroupConfiguration


Description

This PR addresses technical debt and improves the reliability of the TargetGroupConfiguration (TGC) API and controller. It completes several TODO items related to API validation and resource observability.

Key Changes:

  1. API Validation (HealthCheckMatcher):

    • Added a +kubebuilder:validation:XValidation rule to the HealthCheckMatcher struct.
    • This enforces that exactly one of httpCode or grpcCode is specified, providing immediate "fail-fast" validation at the Kubernetes API server level.
  2. Controller Logic (ObservedGeneration):

    • Implemented the ObservedGeneration field in TargetGroupConfigurationStatus.
    • Updated the TGC reconciler to correctly populate this field during the reconciliation loop. This allows users and automation tools to verify that the controller has successfully processed the latest version of the resource.
  3. Automated Testing:

    • Added a new unit test suite: targetgroup_configuration_controller_test.go.
    • Verified that the controller correctly identifies generation changes and updates the status subresource as expected.
  4. Refactoring:

    • Cleaned up associated TODO comments and standardized status field documentation to match existing patterns in the codebase.

Checklist

  • Added tests that cover your change
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested (Verified via go test)
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟 (Converted TODO comments into functional validation and status logic!)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @Nithin0620!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Nithin0620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nithin0620
Once this PR has been reviewed and has the lgtm label, please assign oliviassss for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nithin0620
Copy link
Copy Markdown
Author

@shraddhabang @wweiwei-li
This PR has been ready for review for a while now. Would appreciate a review when possible. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants