feat(gateway): implement validation and status tracking for TargetGroupConfiguration#4731
feat(gateway): implement validation and status tracking for TargetGroupConfiguration#4731Nithin0620 wants to merge 2 commits into
Conversation
|
Welcome @Nithin0620! |
|
Hi @Nithin0620. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nithin0620 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@shraddhabang @wweiwei-li |
PR Title:
feat(gateway): implement validation and status tracking for TargetGroupConfigurationDescription
This PR addresses technical debt and improves the reliability of the
TargetGroupConfiguration(TGC) API and controller. It completes severalTODOitems related to API validation and resource observability.Key Changes:
API Validation (
HealthCheckMatcher):+kubebuilder:validation:XValidationrule to theHealthCheckMatcherstruct.httpCodeorgrpcCodeis specified, providing immediate "fail-fast" validation at the Kubernetes API server level.Controller Logic (
ObservedGeneration):ObservedGenerationfield inTargetGroupConfigurationStatus.Automated Testing:
targetgroup_configuration_controller_test.go.Refactoring:
TODOcomments and standardized status field documentation to match existing patterns in the codebase.Checklist
README.md, or thedocsdirectory)go test)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯
TODOcomments into functional validation and status logic!)