feat(helm): add opt-in Gateway API CRDs to Helm chart

[roulettedares]

Bundles upstream Gateway API v1.5.1 standard and experimental CRDs as opt-in via crds.gatewayAPI.standard.enabled / experimental.enabled (both default false). Raw YAML lives in config/crd/gateway/upstream/ and is copied to helm/files/ by make crds, so verify-crds.sh catches drift automatically. Closes #4687 #4651

Issue

Description

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Welcome @roulettedares!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @roulettedares. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roulettedares
Once this PR has been reviewed and has the lgtm label, please assign wweiwei-li for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shraddhabang]

/ok-to-test

[shraddhabang]

Hey @roulettedares ,Thanks for working on this. While testing this, I found out that the current approach of embedding CRD files in the chart and installing via helm install/helm upgrade doesn't work due to the Helm 1MB release secret limit.

Error: UPGRADE FAILED: create: failed to create: Secret
"sh.helm.release.v1.aws-load-balancer-controller.v2" is invalid:
data: Too long: must have at most 1048576 bytes

I think we need to adopt different approach here. We can keep the CRD files in the same chart but document the install using helm template piped into kubectl apply --server-side. This bypasses the release secret entirely since helm template only renders locally — no Helm release is created. This is the same pattern Envoy Gateway documents for the same reason.

[roulettedares]

I didn't hit this issue since I'm installing via argoCD

kubectl get gatewayclass  2>&1 && echo "---" && kubectl get pods -n kube-system -l
      app.kubernetes.io/name=aws-load-balancer-controller…)
  ⎿  NAME   CONTROLLER            ACCEPTED   AGE
     alb    gateway.k8s.aws/alb   True       99m
     nlb    gateway.k8s.aws/nlb   True       99m

ill update the docs

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: roulettedares / name: Joshua S (96f72b0, acc6b83)

[roulettedares]

@shraddhabang @shuqz @zac-nixon how is this looking?