Handle default certificate as listener SNI certificate

[VPC-byte]

What type of PR is this?

/kind bug

What this PR does / why we need it

When an HTTPS listener is configured with multiple ACM certificates, AWS treats the first listener certificate as the default certificate, but it does not always advertise that default certificate through SNI. This can make clients that depend on SNI matching fail unless users duplicate the default certificate in the extra certificate list manually.

This PR includes the listener default certificate in the desired extra/SNI certificate set, while deduplicating by certificate ARN so the existing duplicate-default workaround does not result in duplicate add requests.

Which issue(s) this PR fixes

Fixes #4090

Special notes for your reviewer

Opened as draft first because I commented on the issue asking whether maintainers prefer automatic reconciliation or an opt-in annotation. The current implementation follows the behavior requested in the issue and keeps duplicate handling idempotent.

Testing

go test ./pkg/deploy/elbv2 -run Test_buildSDKCertificates -count=1 -v
go test ./pkg/deploy/elbv2 -run "Test_buildSDKCertificates|Test_updateSDKListenerWithExtraCertificatesAddsDefaultCertificateToSNI" -count=1 -v
go test ./pkg/deploy/elbv2 -count=1

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VPC-byte
Once this PR has been reviewed and has the lgtm label, please assign zac-nixon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: VPC-byte / name: VPC-byte (4a7232b, 6dee65c)

[k8s-ci-robot]

Welcome @VPC-byte!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @VPC-byte. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.