e2e test: verify num autogenerated security groups for basic service …#4685
e2e test: verify num autogenerated security groups for basic service …#4685bobert-2 wants to merge 1 commit into
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @bobert-2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bobert-2 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| return nil | ||
| } | ||
|
|
||
| func VerifyLoadBalancerSecurityGroups(lb *elbv2types.LoadBalancer, numExpectedSgs int) error { |
There was a problem hiding this comment.
other than SG number, is there anything else worth verifying?
| Scheme: "internet-facing", | ||
| Listeners: stack.resourceStack.getListenersPortMap(), | ||
| TargetGroups: expectedTargetGroups, | ||
| Type: "network", |
There was a problem hiding this comment.
do we only need to verify SG number for those 2 test cases? or there is a plan to cover more
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
3 participants
…nfig
Description
Add basic verification for auto generated security groups.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯