Skip to content

feat: Support for deploying LB to multiple regions using region property on LoadBalancerConfiguration #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksanderaleksic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Support for deploying LB to multiple regions using region property on LoadBalancerConfiguration #4606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apis/gateway/v1beta1/loadbalancerconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,20 @@ type LoadBalancerConfigurationSpec struct {
// +optional
MergingMode *LoadBalancerConfigMergeMode `json:"mergingMode,omitempty"`

// region is the AWS region where the load balancer will be deployed. When unset, the controller's default region is used.
// When set to a different region, vpcId, vpcSelector, or loadBalancerSubnets with identifiers must be set so the VPC can be resolved.
// +optional
Region *string `json:"region,omitempty"`

// vpcId is the VPC ID in the target region. Used when region is set (and especially when it differs from the controller default).
// +optional
VpcID *string `json:"vpcId,omitempty"`

// vpcSelector selects the VPC in the target region by tags. Each key is a tag name; the value list is the allowed tag values.
// A VPC matches if it has each tag key with one of the corresponding values. Exactly one VPC must match in the target region.
// +optional
VpcSelector *map[string][]string `json:"vpcSelector,omitempty"`

// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=32
// loadBalancerName defines the name of the LB to provision. If unspecified, it will be automatically generated.
Expand Down
30 changes: 30 additions & 0 deletions apis/gateway/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions config/crd/gateway/gateway-crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,11 @@ spec:
required:
- capacityUnits
type: object
region:
description: |-
region is the AWS region where the load balancer will be deployed. When unset, the controller's default region is used.
When set to a different region, vpcId, vpcSelector, or loadBalancerSubnets with identifiers must be set so the VPC can be resolved.
type: string
scheme:
description: scheme defines the type of LB to provision. If unspecified,
it will be automatically inferred.
Expand Down Expand Up @@ -772,6 +777,19 @@ spec:
type: string
description: Tags the AWS Tags on all related resources to the gateway.
type: object
vpcId:
description: vpcId is the VPC ID in the target region. Used when region
is set (and especially when it differs from the controller default).
type: string
vpcSelector:
additionalProperties:
items:
type: string
type: array
description: |-
vpcSelector selects the VPC in the target region by tags. Each key is a tag name; the value list is the allowed tag values.
A VPC matches if it has each tag key with one of the corresponding values. Exactly one VPC must match in the target region.
type: object
wafV2:
description: WAFv2 define the AWS WAFv2 settings for a Gateway [Application
Load Balancer]
Expand Down
18 changes: 18 additions & 0 deletions config/crd/gateway/gateway.k8s.aws_loadbalancerconfigurations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,11 @@ spec:
required:
- capacityUnits
type: object
region:
description: |-
region is the AWS region where the load balancer will be deployed. When unset, the controller's default region is used.
When set to a different region, vpcId, vpcSelector, or loadBalancerSubnets with identifiers must be set so the VPC can be resolved.
type: string
scheme:
description: scheme defines the type of LB to provision. If unspecified,
it will be automatically inferred.
Expand Down Expand Up @@ -317,6 +322,19 @@ spec:
type: string
description: Tags the AWS Tags on all related resources to the gateway.
type: object
vpcId:
description: vpcId is the VPC ID in the target region. Used when region
is set (and especially when it differs from the controller default).
type: string
vpcSelector:
additionalProperties:
items:
type: string
type: array
description: |-
vpcSelector selects the VPC in the target region by tags. Each key is a tag name; the value list is the allowed tag values.
A VPC matches if it has each tag key with one of the corresponding values. Exactly one VPC must match in the target region.
type: object
wafV2:
description: WAFv2 define the AWS WAFv2 settings for a Gateway [Application
Load Balancer]
Expand Down
Loading