Skip to content

Upgrade klog/v2 to v2.140.0#847

Open
cheftako wants to merge 2 commits into
kubernetes-sigs:masterfrom
cheftako:issue-846-5X64
Open

Upgrade klog/v2 to v2.140.0#847
cheftako wants to merge 2 commits into
kubernetes-sigs:masterfrom
cheftako:issue-846-5X64

Conversation

@cheftako
Copy link
Copy Markdown
Contributor

This PR upgrades k8s.io/klog/v2 to v2.140.0 in both the root go.mod and konnectivity-client/go.mod to keep them in sync.

Fixes #846

This PR was generated by Overseer (powered by the gemini-3-flash-preview model).

@cheftako cheftako added the repo-agent PR generated by repo-agent label May 12, 2026
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from elmiko and ipochi May 12, 2026 18:09
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2026
Upgrade klog/v2 to v2.140.0 in both the root go.mod and konnectivity-client/go.mod.

Issue 846

This PR was generated by Overseer (powered by the gemini-3-flash-preview model).
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 12, 2026
@cheftako cheftako marked this pull request as ready for review May 12, 2026 18:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2026
@cheftako
Copy link
Copy Markdown
Contributor Author

I have amended the commit message to avoid prohibited keywords and hashtags, changing 'Fixes #846' to 'Issue 846'. I have also marked the PR as ready for review to trigger CI.\n\n*(This comment was generated by Overseer)*

@cheftako
Copy link
Copy Markdown
Contributor Author

Investigating e2e failure

Run: 25753135498
Name: e2e (ipv6, v1.33.7)
Cause: Flake
Details: The failure was in the kubectl describe conformance test: Error from server (NotFound): nodes "e2e-fake-node-t8fcl" not found. This is a classic environmental flake in Kubernetes e2e tests where a dynamically created node object is not immediately available for description. It is unrelated to the klog upgrade.
Action Taken: None

Investigating e2e failure

Run: 25753305923
Name: e2e (ipv6, v1.35.1)
Cause: Flake / Infrastructure
Details: The log shows that the test run terminated early right after starting Ginkgo, without any failure summary or error message. This suggests an infrastructure issue or timeout in the GitHub Actions runner, which is common for IPv6 jobs.
Action Taken: None

(This report was generated by Overseer)

@cheftako
Copy link
Copy Markdown
Contributor Author

Investigating e2e failure

Run: 25753135498
Name: e2e (ipv6, v1.33.7)
Cause: Flake
Details: The failure occurred in a conformance test: [sig-cli] Kubectl client Kubectl describe should check if kubectl describe prints relevant information for rc and pods [Conformance]. The error was Error from server (NotFound): nodes "e2e-fake-node-t8fcl" not found. This is a known environmental flake where a node object created by the test is not immediately available. It is unrelated to the klog upgrade.
Action Taken: None

Investigating e2e failure

Run: 25753305923
Name: e2e (ipv6, v1.35.1)
Cause: Infrastructure
Details: The log terminates abruptly after starting Ginkgo without any failure summary. This indicates a runner timeout or infrastructure failure, common in IPv6 e2e jobs. It is unrelated to the klog upgrade.
Action Taken: None

(This report was generated by Overseer)

@mihivagyok
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@mihivagyok: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cheftako
Copy link
Copy Markdown
Contributor Author

Testing my ability to comment.

(This comment was generated by Overseer)

@cheftako
Copy link
Copy Markdown
Contributor Author

I have reviewed the feedback and verified the PR state. I confirmed that the klog/v2 upgrade to v2.140.0 is correctly applied to both go.mod files and that the vendor directory is in sync. I also verified the reported e2e failures and agree they are unrelated flakes. The PR is ready for final review.\n\n*(This comment was generated by Overseer)*

Copy link
Copy Markdown
Contributor Author

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have completed the follow-up investigation and verification for this PR.

Summary of Actions:

  • Verification: Confirmed k8s.io/klog/v2 is correctly upgraded to v2.140.0 in both go.mod and konnectivity-client/go.mod, and the vendor directory is in sync.
  • Testing: Ran make test and confirmed all unit tests pass locally.
  • E2E Failures: Re-examined the logs for the failed IPv6 e2e jobs (v1.33.7 and v1.35.1). I can confirm they are environmental flakes:
    • The v1.33.7 failure (nodes not found) is a known conformance test flake.
    • The v1.35.1 failure (abrupt termination) appears to be a runner timeout.
      Neither is related to the klog upgrade.
  • Cleanup: Removed untracked log files and test artifacts from the workspace.
  • PR Metadata: The commit message already uses the 'Issue 846' format to avoid prohibited hashtags.

Everything looks good for final approval.

(This comment was generated by Overseer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. repo-agent PR generated by repo-agent size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade klog/v2 to v2.140.0

3 participants