Skip to content

Upgrade prometheus/client_golang to v1.23.2 & prometheus/common to v0.67.5#839

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
cheftako:issue-838-cFIo
May 18, 2026
Merged

Upgrade prometheus/client_golang to v1.23.2 & prometheus/common to v0.67.5#839
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
cheftako:issue-838-cFIo

Conversation

@cheftako
Copy link
Copy Markdown
Contributor

@cheftako cheftako commented May 8, 2026

Please upgrade the top level go.mod file.
We should be using the v1.23.2 version of the prometheus/client_golang library.
We should be using the v0.67.5 version of the prometheus/common library.
Run go mod tidy and go mod vendor once go.mod is finished.
Please make sure the tests pass.

Issue #838

This PR was generated by Overseer (powered by the gemini-3-flash-preview model).

….67.5

Issue kubernetes-sigs#838

This PR was generated by Overseer (powered by the gemini-3-flash-preview model).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2026
@k8s-ci-robot k8s-ci-robot requested review from elmiko and tallclair May 8, 2026 18:14
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2026
@cheftako
Copy link
Copy Markdown
Contributor Author

cheftako commented May 8, 2026

I have verified that the top-level go.mod file has been upgraded to prometheus/client_golang v1.23.2 and prometheus/common v0.67.5 as requested. I have also confirmed that 'go mod tidy' and 'go mod vendor' have been run and that all unit tests pass. Thank you for the approval.

(This comment was generated by Overseer)

@cheftako
Copy link
Copy Markdown
Contributor Author

cheftako commented May 8, 2026

Investigating e2e failure

Run: 25571827082
Name: e2e
Cause: Code Error
Details: The upgrade to prometheus/common v0.67.5 introduced a requirement to explicitly set a validation scheme in expfmt.TextParser. The e2e tests were using the zero-value of TextParser, which resulted in a panic: panic: Invalid name validation scheme requested: unset.
Action Taken: Fixed the panic by using expfmt.NewTextParser(model.LegacyValidation) in e2e/metrics_assertions_test.go and tests/framework/metrics.go.

(This report was generated by Overseer)

@cheftako
Copy link
Copy Markdown
Contributor Author

/assign @barney-s

@cheftako
Copy link
Copy Markdown
Contributor Author

/assign @justinsb

Copy link
Copy Markdown
Contributor

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 24d61ca into kubernetes-sigs:master May 18, 2026
22 checks passed
@cheftako
Copy link
Copy Markdown
Contributor Author

I have verified that the top-level go.mod has been upgraded to prometheus/client_golang v1.23.2 and prometheus/common v0.67.5. I have also confirmed that the e2e test panic has been fixed in the second commit by using expfmt.NewTextParser(model.LegacyValidation). All unit tests and integration tests passed. The PR is approved and ready for merge.

(This comment was generated by Overseer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants