Upgrade top level dependencies to K/K v0.36#832
Conversation
Prompt:
please upgrade the top level go.mod to use go version 1.26.0. Ensure all the tests pass. Do not make changes in konnectivity-client.
All tests pass. Here's a summary of what was done:
Dependency upgrades (matching kubernetes/kubernetes go.mod):
- k8s.io/{api,apimachinery,client-go,component-base,component-helpers}: v0.34.0 → v0.36.0
- k8s.io/klog/v2: v2.130.1 → v2.140.0
- k8s.io/utils: v0.0.0-20250604 → v0.0.0-20260210
- k8s.io/kube-openapi: updated to v0.0.0-20260502
- sigs.k8s.io/controller-runtime: v0.20.3 → v0.24.0 (required to match k8s v0.36.0)
- sigs.k8s.io/apiserver-network-proxy/konnectivity-client: v0.31.0 → v0.34.0
- google.golang.org/grpc: v1.79.3 → v1.80.0
- google.golang.org/protobuf: v1.36.10 → v1.36.12-pre
- golang.org/x/{net,sys,term,text,oauth2,time}: various patch upgrades
- go.opentelemetry.io/otel{,/trace}: v1.41.0 → v1.43.0
- github.com/prometheus/client_golang: v1.23.0 → v1.23.2
- Various other smaller bumps
Code fix required: NewLeaseInformerWithMetrics in pkg/agent/lease_counter.go — the WatchListClient feature gate became enabled by default in k8s
v1.35+, so the reflector now expects bookmark events. Wrapping the ListWatch with cache.ToListWatcherWithWatchListSemantics(lw, client) properly
propagates the fake client's signal that it doesn't support WatchList semantics, fixing a test hang.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@cheftako: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
My PR is similar: I wonder if similar updates can be done in earlier releases. Thanks! |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
It can, how far back would you like this cherry picked? |
3 participants
Prompt:
please upgrade the top level go.mod to use go version 1.26.0. Ensure all the tests pass. Do not make changes in konnectivity-client.
All tests pass. Here's a summary of what was done:
Dependency upgrades (matching kubernetes/kubernetes go.mod):
Code fix required: NewLeaseInformerWithMetrics in pkg/agent/lease_counter.go — the WatchListClient feature gate became enabled by default in k8s
v1.35+, so the reflector now expects bookmark events. Wrapping the ListWatch with cache.ToListWatcherWithWatchListSemantics(lw, client) properly
propagates the fake client's signal that it doesn't support WatchList semantics, fixing a test hang.