Skip to content

server: avoid selecting draining backends#821

Open
ipochi wants to merge 1 commit into
kubernetes-sigs:masterfrom
kinvolk:imran/agrent-draining-large-clusters-concern
Open

server: avoid selecting draining backends#821
ipochi wants to merge 1 commit into
kubernetes-sigs:masterfrom
kinvolk:imran/agrent-draining-large-clusters-concern

Conversation

@ipochi
Copy link
Copy Markdown
Contributor

@ipochi ipochi commented Apr 24, 2026

Track non-draining backend candidates so selection avoids scanning and
does not route new requests to draining backends when healthy choices
exist.

go test ./pkg/server -count=1
go test ./pkg/server -race -run Test(DefaultBackendManager_GetRandomBackend_LazilyEvictsDrainingCandidate|DestHostBackendManager_Backend_DrainingFallback|DestHostBackendManager_Backend_DistributesAcrossNonDrainingCandidates|DestHostBackendManager_NonDrainingCacheTracksCurrentBackends)$'
-count=1

Track non-draining backend candidates for default and dest-host routing,
and update the dest-host cache atomically with backend add/remove.

Add tests for non-draining selection, lazy eviction, and draining
fallback behavior.

Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ipochi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2026
@ipochi
Copy link
Copy Markdown
Contributor Author

ipochi commented Apr 27, 2026

/retest

@ipochi ipochi requested a review from cheftako April 27, 2026 18:46
@cheftako
Copy link
Copy Markdown
Contributor

cheftako commented May 1, 2026

@ipochi I fixed a bunch of problems on CI. I think if you rebase on the latest this should go better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants