Skip to content

chore(bump): bump dependencies to last kubernetes version#818

Open
ricardomaraschini wants to merge 5 commits into
kubernetes-sigs:masterfrom
ricardomaraschini:bump-to-kube-1.35
Open

chore(bump): bump dependencies to last kubernetes version#818
ricardomaraschini wants to merge 5 commits into
kubernetes-sigs:masterfrom
ricardomaraschini:bump-to-kube-1.35

Conversation

@ricardomaraschini
Copy link
Copy Markdown

This PR updates the Kubernetes dependencies to v1.35 and fixes the lease informer to respect the new watch/list semantics introduced in Kubernetes 1.35.

Dependency Updates

Package From To
k8s.io/api v0.34.0 v0.35.3
k8s.io/apimachinery v0.34.0 v0.35.3
k8s.io/client-go v0.34.0 v0.35.3
k8s.io/component-base v0.34.0 v0.35.3
k8s.io/component-helpers v0.34.0 v0.35.3
k8s.io/klog/v2 v2.130.1 v2.140.0
k8s.io/utils v0.0.0-20250604170112 v0.0.0-20260319190234
sigs.k8s.io/controller-runtime v0.20.3 v0.23.3
google.golang.org/grpc v1.72.1 v1.80.0
google.golang.org/protobuf v1.36.6 v1.36.11
github.com/prometheus/client_golang v1.23.0 v1.23.2
github.com/prometheus/common v0.65.0 v0.66.1
github.com/spf13/cobra v1.10.1 v1.10.2
github.com/stretchr/testify v1.10.0 v1.11.1
go.uber.org/mock v0.5.2 v0.6.0
golang.org/x/net v0.40.0 v0.49.0

Code Changes

Informer Watch List Semantics Fix (pkg/agent/lease_counter.go)

Updated the lease informer to respect Kubernetes 1.35's new watch/list semantics by wrapping the ListWatch with cache.ToListWatcherWithWatchListSemantics().

bump kubernetes dependencies to the latest kubernetes version.
fix informer to respect the client option with regards to the new
watch/list semantics.
@k8s-ci-robot k8s-ci-robot requested review from elmiko and ipochi April 1, 2026 14:05
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
Once this PR has been reviewed and has the lgtm label, please assign jkh52 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2026
we are now using go 1.25 so this one needs to be bumped.
bump default go version to 1.25.
the context seems to be based on Background().
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@ricardomaraschini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-apiserver-network-proxy-test-master f390611 link true /test pull-apiserver-network-proxy-test-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

github.com/prometheus/client_golang v1.23.2
go.uber.org/goleak v1.3.0
golang.org/x/net v0.49.0 // indirect
google.golang.org/grpc v1.80.0
Copy link
Copy Markdown
Contributor

@cheftako cheftako Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be upgrading the dependencies of the oldest supported K/K version (For the konnectivity-client/go.mod). (Which I believe is 1.33). https://github.com/kubernetes/kubernetes/blob/release-1.33/go.mod shows a grpc version of v1.68.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good idea to keep changes to konnectivity-client (our library) separate from changes to the rest of the repo. (our services)

@hrak hrak mentioned this pull request Apr 10, 2026
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants