chore(bump): bump dependencies to last kubernetes version#818
chore(bump): bump dependencies to last kubernetes version#818ricardomaraschini wants to merge 5 commits into
Conversation
bump kubernetes dependencies to the latest kubernetes version.
fix informer to respect the client option with regards to the new watch/list semantics.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
we are now using go 1.25 so this one needs to be bumped.
bump default go version to 1.25.
the context seems to be based on Background().
|
@ricardomaraschini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| github.com/prometheus/client_golang v1.23.2 | ||
| go.uber.org/goleak v1.3.0 | ||
| golang.org/x/net v0.49.0 // indirect | ||
| google.golang.org/grpc v1.80.0 |
There was a problem hiding this comment.
We shouldn't be upgrading the dependencies of the oldest supported K/K version (For the konnectivity-client/go.mod). (Which I believe is 1.33). https://github.com/kubernetes/kubernetes/blob/release-1.33/go.mod shows a grpc version of v1.68.1
There was a problem hiding this comment.
Generally a good idea to keep changes to konnectivity-client (our library) separate from changes to the rest of the repo. (our services)
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR updates the Kubernetes dependencies to v1.35 and fixes the lease informer to respect the new watch/list semantics introduced in Kubernetes 1.35.
Dependency Updates
Code Changes
Informer Watch List Semantics Fix (
pkg/agent/lease_counter.go)Updated the lease informer to respect Kubernetes 1.35's new watch/list semantics by wrapping the
ListWatchwithcache.ToListWatcherWithWatchListSemantics().