Skip to content

refactor(metrics): restructure pkg/metrics and expose GetMetrics for volume Prometheus metrics#1623

Open
iltyty wants to merge 7 commits into
kubernetes-sigs:masterfrom
iltyty:acs-metrics
Open

refactor(metrics): restructure pkg/metrics and expose GetMetrics for volume Prometheus metrics#1623
iltyty wants to merge 7 commits into
kubernetes-sigs:masterfrom
iltyty:acs-metrics

Conversation

@iltyty
Copy link
Copy Markdown
Contributor

@iltyty iltyty commented Jan 29, 2026

What type of PR is this?

/kind refactor

What this PR does / why we need it:

Restructure pkg/metrics and expose GetMetrics for volume Prometheus metrics.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@iltyty: The label(s) kind/refactor cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind refactor

What this PR does / why we need it:

Restructure pkg/metrics and expose GetMetrics for volume Prometheus metrics.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iltyty
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2026
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@iltyty: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-alibaba-cloud-csi-driver-verify-unit 80331ee link true /test pull-alibaba-cloud-csi-driver-verify-unit
pull-alibaba-cloud-csi-driver-verify-fmt 80331ee link true /test pull-alibaba-cloud-csi-driver-verify-fmt
pull-alibaba-cloud-csi-driver-verify-vet 80331ee link true /test pull-alibaba-cloud-csi-driver-verify-vet
pull-alibaba-cloud-csi-driver-verify-deps 80331ee link true /test pull-alibaba-cloud-csi-driver-verify-deps
pull-alibaba-cloud-csi-driver-verify-lint 80331ee link true /test pull-alibaba-cloud-csi-driver-verify-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants