Skip to content

fix(ci): pin pnpm via pnpm/action-setup@v4 and harden playwright version detection #4091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab-smith merged 2 commits into from
May 7, 2026
+56 −42
Merged

fix(ci): pin pnpm via pnpm/action-setup@v4 and harden playwright version detection #4091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e56c924
fix(ci): pin pnpm via pnpm/action-setup@v4 and harden playwright vers…
ab-smith May 7, 2026
bf97694
use v5 for deprecation warning (we'll move to 6 soon)
ab-smith May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/frontend-coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install latest pnpm
working-directory: ${{env.working-directory}}
run: |
npm install -g pnpm &&
pnpm --version &&
pnpm list -g --depth 0
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10
- name: Install dependencies
working-directory: ${{env.working-directory}}
run: pnpm i --frozen-lockfile
Expand Down
20 changes: 8 additions & 12 deletions .github/workflows/frontend-linters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install latest pnpm
working-directory: ${{env.working-directory}}
run: |
npm install -g pnpm &&
pnpm --version &&
pnpm list -g --depth 0
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10
- name: Install prettier
working-directory: ${{env.working-directory}}
run: pnpm add --save-dev prettier
Expand Down Expand Up @@ -74,12 +72,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install latest pnpm
working-directory: ${{env.working-directory}}
run: |
npm install -g pnpm &&
pnpm --version &&
pnpm list -g --depth 0
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10
- name: Install prettier
working-directory: ${{env.working-directory}}
run: pnpm add --save-dev prettier
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/frontend-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install latest pnpm
working-directory: ${{env.working-directory}}
run: |
npm install -g pnpm &&
pnpm --version &&
pnpm list -g --depth 0
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10
- name: Install dependencies
working-directory: ${{env.working-directory}}
run: pnpm i --frozen-lockfile
Expand Down
34 changes: 24 additions & 10 deletions .github/workflows/functional-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ jobs:
restore-keys: |
${{ runner.os }}-pnpm-

- name: Install pnpm globally
run: npm install -g pnpm
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10

- name: Install community frontend dependencies
working-directory: ${{ env.frontend-directory }}
Expand Down Expand Up @@ -94,8 +96,10 @@ jobs:
restore-keys: |
${{ runner.os }}-pnpm-

- name: Install pnpm globally
run: npm install -g pnpm
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10

- name: Build enterprise frontend
working-directory: ${{ env.enterprise-frontend-directory }}
Expand Down Expand Up @@ -238,16 +242,21 @@ jobs:
restore-keys: |
${{ runner.os }}-pnpm-

- name: Install pnpm globally
run: npm install -g pnpm
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10

- name: Install community frontend dependencies (if not cached/part of build artifact)
working-directory: ${{ env.frontend-directory }}
run: pnpm i --frozen-lockfile

- name: Get installed Playwright version
id: playwright-version
run: echo "PLAYWRIGHT_VERSION=$(pnpm exec playwright --version | awk -F ' ' '{print $2}')" >> $GITHUB_ENV
working-directory: ${{ env.frontend-directory }}
run: |
PLAYWRIGHT_VERSION=$(node -p "require('@playwright/test/package.json').version")
echo "PLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION" >> "$GITHUB_ENV"

- name: Cache playwright binaries
uses: actions/cache@v4
Expand Down Expand Up @@ -414,16 +423,21 @@ jobs:
working-directory: ${{ env.enterprise-frontend-directory }}
run: make pre-build

- name: Install pnpm globally
run: npm install -g pnpm
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10

- name: Install enterprise frontend dependencies
working-directory: ${{ env.enterprise-frontend-build-directory }}
run: pnpm i --frozen-lockfile

- name: Get installed Playwright version
id: playwright-version
run: echo "PLAYWRIGHT_VERSION=$(pnpm exec playwright --version | awk -F ' ' '{print $2}')" >> $GITHUB_ENV
working-directory: ${{ env.enterprise-frontend-build-directory }}
run: |
PLAYWRIGHT_VERSION=$(node -p "require('@playwright/test/package.json').version")
echo "PLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION" >> "$GITHUB_ENV"

- name: Cache playwright binaries
uses: actions/cache@v4
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/rpm-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,15 @@ jobs:
ncurses-devel \
gdbm-devel

- name: Install Node.js and pnpm
- name: Install Node.js
run: |
curl -fsSL https://rpm.nodesource.com/setup_22.x | bash -
dnf install -y nodejs
npm install -g pnpm

- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10

- name: Install Poetry
run: |
Expand Down
16 changes: 10 additions & 6 deletions .github/workflows/startup-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,13 @@ jobs:
- name: Install backend requirements
working-directory: ${{ env.backend-directory }}
run: poetry install
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10
- name: Install frontend dependencies
working-directory: ${{ env.frontend-directory }}
run: |
npm install -g pnpm
pnpm i --frozen-lockfile
run: pnpm i --frozen-lockfile
- name: Install Playwright Browsers
working-directory: ${{ env.frontend-directory }}
run: pnpm exec playwright install
Expand Down Expand Up @@ -131,11 +133,13 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: lts/*
- name: Install pnpm
uses: pnpm/action-setup@v5
with:
version: 10
- name: Install frontend dependencies
working-directory: ${{ env.frontend-directory }}
run: |
npm install -g pnpm
pnpm i --frozen-lockfile
run: pnpm i --frozen-lockfile
- name: Install Playwright Browsers
working-directory: ${{ env.frontend-directory }}
run: pnpm exec playwright install
Expand Down
Loading