Skip to content

Replace eslint-plugin-json with a fixture processor#3252

Merged
ljharb merged 1 commit into
import-js:mainfrom
rasmi:json-fixture
May 19, 2026
Merged

Replace eslint-plugin-json with a fixture processor#3252
ljharb merged 1 commit into
import-js:mainfrom
rasmi:json-fixture

Conversation

@rasmi
Copy link
Copy Markdown
Contributor

@rasmi rasmi commented May 18, 2026

While updating to support eslint v10 in #3230, eslint-plugin-json (and specifically eslint-plugin-jsonc for v10+) caused a series of interrelated version/dependency issues which required various dep-time-travel.sh and version-pinning workarounds (see here).

The #1645 regression test only needs some .json processor in the pipeline so no-unused-modules is exercised against a JSON-only directory (the bug was the import rule crashing there, not the JSON diagnostic). The fixture does that and removes the JSON-plugin dependency entirely.

(potential alternative to #3230's eslint-plugin-jsonc switch d8d7294)

@rasmi rasmi mentioned this pull request May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.77%. Comparing base (1ab0c39) to head (7b153c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3252      +/-   ##
==========================================
+ Coverage   95.50%   95.77%   +0.27%     
==========================================
  Files          83       83              
  Lines        3692     3693       +1     
  Branches     1335     1336       +1     
==========================================
+ Hits         3526     3537      +11     
+ Misses        166      156      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb ljharb merged commit 7b153c2 into import-js:main May 19, 2026
434 of 451 checks passed
@rasmi
Copy link
Copy Markdown
Contributor Author

rasmi commented May 20, 2026

Will remove the workarounds in #3230 today and rebase on main!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants