Replace eslint-plugin-json with a fixture processor#3252
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3252 +/- ##
==========================================
+ Coverage 95.50% 95.77% +0.27%
==========================================
Files 83 83
Lines 3692 3693 +1
Branches 1335 1336 +1
==========================================
+ Hits 3526 3537 +11
+ Misses 166 156 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ljharb
approved these changes
May 18, 2026
Contributor
Author
|
Will remove the workarounds in #3230 today and rebase on main! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating to support eslint v10 in #3230,
eslint-plugin-json(and specificallyeslint-plugin-jsoncfor v10+) caused a series of interrelated version/dependency issues which required variousdep-time-travel.shand version-pinning workarounds (see here).The #1645 regression test only needs some
.jsonprocessor in the pipeline sono-unused-modulesis exercised against a JSON-only directory (the bug was the import rule crashing there, not the JSON diagnostic). The fixture does that and removes the JSON-plugin dependency entirely.(potential alternative to #3230's
eslint-plugin-jsoncswitch d8d7294)