Skip to content

Remove stray errors from valid tests.#3251

Merged
ljharb merged 1 commit into
import-js:mainfrom
rasmi:test-cleanup
May 18, 2026
Merged

Remove stray errors from valid tests.#3251
ljharb merged 1 commit into
import-js:mainfrom
rasmi:test-cleanup

Conversation

@rasmi
Copy link
Copy Markdown
Contributor

@rasmi rasmi commented May 18, 2026

These valid cases carried errors arrays that never fired: named's checkRequire early-returns unless commonjs: true (54d86c8), and no-dynamic-require only flags import() with esmodule: true (7163824), which these cases don't set. Pre-v10 RuleTester silently ignored errors/output on valid cases; ESLint v10's RuleTester rejects them, which is what surfaced these in #3230. Correctly-configured versions already exist.

Extracted from #3230 to keep that PR clean. (see context here and here and here).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.50%. Comparing base (00fa198) to head (1ab0c39).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
- Coverage   95.64%   95.50%   -0.14%     
==========================================
  Files          83       83              
  Lines        3693     3692       -1     
  Branches     1336     1335       -1     
==========================================
- Hits         3532     3526       -6     
- Misses        161      166       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb ljharb merged commit 1ab0c39 into import-js:main May 18, 2026
386 of 403 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants